Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing characters in wizard is very slow #446

Closed
roedoejet opened this issue May 30, 2024 · 1 comment · Fixed by #464
Closed

Processing characters in wizard is very slow #446

roedoejet opened this issue May 30, 2024 · 1 comment · Fixed by #464
Assignees
@joanise
Labels
enhancement New feature or request

Comments

@roedoejet
Copy link
Member

I'm working with a large dataset (111K utterances) and it looks like it will currently take about 1.5 hours to process everything. We should get this quicker.
@roedoejet roedoejet added enhancement New feature or request help wanted Extra attention is needed labels May 30, 2024
@roedoejet
Copy link
Member Author

The issue is that g2p is slow, so if you say that the input is characters, it will process all the utterances into phones as well and that's what is taking the time. If I lie and say that the input is phones already, it takes 36 seconds

@joanise joanise self-assigned this Jun 13, 2024
@joanise joanise removed the help wanted Extra attention is needed label Jun 13, 2024
joanise added a commit that referenced this issue Jun 13, 2024
@joanise
perf: speed up g2p processing by caching the results
32a4813 
The cache is implemented on a token basis to keep the results
identical but maximize reuse potential.

Fixes: #446
@joanise joanise mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanise joanise

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: speed up g2p processing by caching the results EveryVoiceTTS/EveryVoice
2 participants
@roedoejet @joanise