Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call I2C on a different thread #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Call I2C on a different thread #50

wants to merge 2 commits into from

Conversation

ExcaliburFRC6738
Copy link
Member

No description provided.

@CohenAriel
Copy link
Contributor

thred?

@ExcaliburFRC6738
Copy link
Member Author

thred?

thread

@Starlight220 Starlight220 changed the title thred-sensor Call I2C on a different thread Feb 21, 2022
Starlight220
Starlight220 requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also use this instead of ColorSensorV3 in the Intake subsystem?

src/main/java/io/excaliburfrc/lib/ThreadedColorSensor.java

private static final double THRESHOLD = 0.5; // TODO: change that

ColorSensorV3 sensor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be private and final; we don't want it to be accessible or change

@Starlight220
Copy link
Member

Needs review addressed and rebase (shouldn't be much of a problem, this doesn't conflict with anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starlight220 Starlight220 Starlight220 requested changes

@TapChap TapChap Awaiting requested review from TapChap

Requested changes must be addressed to merge this pull request.

Assignees

@spaderski spaderski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ExcaliburFRC6738 @CohenAriel @Starlight220 @spaderski