Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom CodeQL query for null iterator deref #1768

Merged

Conversation

kevinbackhouse
Copy link
Collaborator

Add the CodeQL query that I wrote for #1758 so that similar bugs will be prevented in the future.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1768 (fb824ac) into main (43fe7bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files         151      151           
  Lines       20799    20799           
=======================================
  Hits        13997    13997           
  Misses       6802     6802           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fe7bb...fb824ac. Read the comment docs.

@kevinbackhouse kevinbackhouse marked this pull request as draft July 8, 2021 13:39
@kevinbackhouse kevinbackhouse force-pushed the codeql-null-iterator-deref branch from 72b9840 to fb824ac Compare July 8, 2021 15:51
@kevinbackhouse
Copy link
Collaborator Author

The query has two results, as expected.
This query would have caught the bug reported in #1763.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review July 8, 2021 16:07
Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinbackhouse this looks like a fantastic addition!

This CodeQL scanning really is a great tool!

@kevinbackhouse kevinbackhouse merged commit c7757d7 into Exiv2:main Jul 9, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants