From 7b673a53b08d2e7d37cfaacbc8ec81844ba3dbae Mon Sep 17 00:00:00 2001 From: Timon Pike Date: Thu, 31 Aug 2023 15:43:07 -0700 Subject: [PATCH] re-enable online_store.update for aws provider --- sdk/python/feast/feature_store.py | 11 ----------- sdk/python/feast/infra/aws.py | 18 +++++++++--------- sdk/python/feast/infra/passthrough_provider.py | 2 -- 3 files changed, 9 insertions(+), 22 deletions(-) diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py index 45d4500800..04f0f8b5d1 100644 --- a/sdk/python/feast/feature_store.py +++ b/sdk/python/feast/feature_store.py @@ -821,8 +821,6 @@ def apply( ... ) >>> fs.apply([driver_hourly_stats_view, driver]) # register entity and feature view """ - # TODO: remove - print(f"Apply with: {objects}") # TODO: Add locking if not isinstance(objects, Iterable): objects = [objects] @@ -993,15 +991,6 @@ def apply( tables_to_delete: List[FeatureView] = views_to_delete + sfvs_to_delete if not partial else [] # type: ignore tables_to_keep: List[FeatureView] = views_to_update + sfvs_to_update # type: ignore - # TODO: remove - print( - f"""Update project={self.project}, - tables_to_delete={tables_to_delete}, - tables_to_keep={tables_to_keep}, - entities_to_delete={entities_to_delete if not partial else []}, - entities_to_keep={entities_to_update}, - partial={partial},""" - ) self._get_provider().update_infra( project=self.project, tables_to_delete=tables_to_delete, diff --git a/sdk/python/feast/infra/aws.py b/sdk/python/feast/infra/aws.py index 6e0fa7a563..5baa569806 100644 --- a/sdk/python/feast/infra/aws.py +++ b/sdk/python/feast/infra/aws.py @@ -57,15 +57,15 @@ def update_infra( # from online stores when a Feature View is deleted. # Call update only if there is an online store - # if self.online_store: - # self.online_store.update( - # config=self.repo_config, - # tables_to_delete=tables_to_delete, - # tables_to_keep=tables_to_keep, - # entities_to_keep=entities_to_keep, - # entities_to_delete=entities_to_delete, - # partial=partial, - # ) + if self.online_store: + self.online_store.update( + config=self.repo_config, + tables_to_delete=tables_to_delete, + tables_to_keep=tables_to_keep, + entities_to_keep=entities_to_keep, + entities_to_delete=entities_to_delete, + partial=partial, + ) if self.repo_config.feature_server and self.repo_config.feature_server.enabled: warnings.warn( diff --git a/sdk/python/feast/infra/passthrough_provider.py b/sdk/python/feast/infra/passthrough_provider.py index c3917a5398..28b10c1259 100644 --- a/sdk/python/feast/infra/passthrough_provider.py +++ b/sdk/python/feast/infra/passthrough_provider.py @@ -116,8 +116,6 @@ def update_infra( ): set_usage_attribute("provider", self.__class__.__name__) - # TODO: remove - print(f"Is online store={self.online_store}") # Call update only if there is an online store if self.online_store: self.online_store.update(