feat: Use official graphql java 22 version #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Jun 20, 2024
| api(libs.graphql.java) { | ||
| exclude(group = "com.graphql-java", module = "java-dataloader") | ||
| } | ||
| testImplementation(projects.graphqlKotlinServer) |
Collaborator
There was a problem hiding this comment.
why do you need to bring this dependency?
Contributor
Author
There was a problem hiding this comment.
It's to have access to the dataFetchingEnvironmentExtensions in the tests.
Collaborator
There was a problem hiding this comment.
I think it is somewhat problematic as you end up with cyclic dependency -> i.e. graphql-kotlin-server depends on graphql-kotlin-dataloader-instrumentation as API dependency (link) and we depend here on the server as a test dependency.
Guessing Gradle is smart enough to handle the API vs test dependency.... but I'd avoid it and either copy over the extension locally to one of the tests or simply do what extension does....
dariuszkuc
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Follow up to #1967 to use an official graphql java release.