From 3a8a8d509895703abeef941ae2784af87eb5eb02 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 22 Jun 2023 12:57:18 -0600 Subject: [PATCH 1/2] pass empty function --- src/pages/home/report/ReportActionItem.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/home/report/ReportActionItem.js b/src/pages/home/report/ReportActionItem.js index 24be64dc6468..2f0ba9995d26 100644 --- a/src/pages/home/report/ReportActionItem.js +++ b/src/pages/home/report/ReportActionItem.js @@ -449,6 +449,7 @@ function ReportActionItem(props) { ref={popoverAnchorRef} onPressIn={() => props.isSmallScreenWidth && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()} onPressOut={() => ControlSelection.unblock()} + onPress={() => {}} onSecondaryInteraction={showPopover} preventDefaultContextMenu={!props.draftMessage && !hasErrors} withoutFocusOnSecondaryInteraction From dfc0d5f145ec21846413549b3d287a00c313bfa8 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 22 Jun 2023 13:12:14 -0600 Subject: [PATCH 2/2] use lambda as default --- src/components/Pressable/GenericPressable/PropTypes.js | 2 +- src/pages/home/report/ReportActionItem.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/Pressable/GenericPressable/PropTypes.js b/src/components/Pressable/GenericPressable/PropTypes.js index 588161031e10..9e2b45b54b81 100644 --- a/src/components/Pressable/GenericPressable/PropTypes.js +++ b/src/components/Pressable/GenericPressable/PropTypes.js @@ -121,7 +121,7 @@ const pressablePropTypes = { }; const defaultProps = { - onPress: undefined, + onPress: () => {}, keyboardShortcut: undefined, shouldUseHapticsOnPress: false, shouldUseHapticsOnLongPress: false, diff --git a/src/pages/home/report/ReportActionItem.js b/src/pages/home/report/ReportActionItem.js index 2f0ba9995d26..24be64dc6468 100644 --- a/src/pages/home/report/ReportActionItem.js +++ b/src/pages/home/report/ReportActionItem.js @@ -449,7 +449,6 @@ function ReportActionItem(props) { ref={popoverAnchorRef} onPressIn={() => props.isSmallScreenWidth && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()} onPressOut={() => ControlSelection.unblock()} - onPress={() => {}} onSecondaryInteraction={showPopover} preventDefaultContextMenu={!props.draftMessage && !hasErrors} withoutFocusOnSecondaryInteraction