From 025867d8eac6a6125bc388a6bb31746ef7a4b96c Mon Sep 17 00:00:00 2001 From: 289Adam289 Date: Thu, 22 Aug 2024 10:43:48 +0200 Subject: [PATCH 1/3] fix save button bug --- .../Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx | 1 + .../Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx | 1 + src/pages/Search/SearchFiltersAmountPage.tsx | 1 + src/pages/Search/SearchFiltersCardPage.tsx | 1 + src/pages/Search/SearchFiltersCategoryPage.tsx | 1 + src/pages/Search/SearchFiltersCurrencyPage.tsx | 1 + src/pages/Search/SearchFiltersDatePage.tsx | 1 + src/pages/Search/SearchFiltersDescriptionPage.tsx | 1 + src/pages/Search/SearchFiltersExpenseTypePage.tsx | 1 + src/pages/Search/SearchFiltersKeywordPage.tsx | 1 + src/pages/Search/SearchFiltersMerchantPage.tsx | 1 + src/pages/Search/SearchFiltersReportIDPage.tsx | 1 + src/pages/Search/SearchFiltersTagPage.tsx | 1 + src/pages/Search/SearchFiltersTaxRatePage.tsx | 1 + 14 files changed, 14 insertions(+) diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx index aca90d3721d8..71918a8ee1de 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx @@ -21,6 +21,7 @@ function SearchFiltersFromPage() { includeSafeAreaPaddingBottom={false} shouldShowOfflineIndicatorInWideScreen offlineIndicatorStyle={styles.mtAuto} + shouldEnableMaxHeight > diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx index 6437b5a7e757..7c7ad1119b68 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx @@ -21,6 +21,7 @@ function SearchFiltersToPage() { includeSafeAreaPaddingBottom={false} shouldShowOfflineIndicatorInWideScreen offlineIndicatorStyle={styles.mtAuto} + shouldEnableMaxHeight > diff --git a/src/pages/Search/SearchFiltersAmountPage.tsx b/src/pages/Search/SearchFiltersAmountPage.tsx index d7533f9ac20e..56eb3dce4350 100644 --- a/src/pages/Search/SearchFiltersAmountPage.tsx +++ b/src/pages/Search/SearchFiltersAmountPage.tsx @@ -44,6 +44,7 @@ function SearchFiltersAmountPage() { shouldShowOfflineIndicatorInWideScreen offlineIndicatorStyle={styles.mtAuto} includeSafeAreaPaddingBottom={false} + shouldEnableMaxHeight > Date: Thu, 22 Aug 2024 14:31:42 +0200 Subject: [PATCH 2/3] fix view results button --- src/pages/Search/AdvancedSearchFilters.tsx | 40 ++++++++++++---------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/src/pages/Search/AdvancedSearchFilters.tsx b/src/pages/Search/AdvancedSearchFilters.tsx index 5143a2d70008..4b859e37785e 100644 --- a/src/pages/Search/AdvancedSearchFilters.tsx +++ b/src/pages/Search/AdvancedSearchFilters.tsx @@ -225,31 +225,33 @@ function AdvancedSearchFilters() { }; return ( - - - {advancedFilters.map((item) => { - const onPress = singleExecution(waitForNavigate(() => Navigation.navigate(item.route))); - if (item.shouldHide) { - return undefined; - } - return ( - - ); - })} - + <> + + + {advancedFilters.map((item) => { + const onPress = singleExecution(waitForNavigate(() => Navigation.navigate(item.route))); + if (item.shouldHide) { + return undefined; + } + return ( + + ); + })} + + - + ); } From 32ff110118050a10655cbe055e51575597251c63 Mon Sep 17 00:00:00 2001 From: 289Adam289 Date: Thu, 22 Aug 2024 14:32:23 +0200 Subject: [PATCH 3/3] reorganize directory structure --- .../ModalStackNavigators/index.tsx | 24 +++++++++---------- .../SearchFiltersAmountPage.tsx | 0 .../SearchFiltersCardPage.tsx | 0 .../SearchFiltersCategoryPage.tsx | 0 .../SearchFiltersCurrencyPage.tsx | 0 .../SearchFiltersDatePage.tsx | 0 .../SearchFiltersDescriptionPage.tsx | 0 .../SearchFiltersExpenseTypePage.tsx | 0 .../SearchFiltersKeywordPage.tsx | 0 .../SearchFiltersMerchantPage.tsx | 0 .../SearchFiltersReportIDPage.tsx | 0 .../SearchFiltersTagPage.tsx | 0 .../SearchFiltersTaxRatePage.tsx | 0 13 files changed, 12 insertions(+), 12 deletions(-) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersAmountPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersCardPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersCategoryPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersCurrencyPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersDatePage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersDescriptionPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersExpenseTypePage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersKeywordPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersMerchantPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersReportIDPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersTagPage.tsx (100%) rename src/pages/Search/{ => SearchAdvancedFiltersPage}/SearchFiltersTaxRatePage.tsx (100%) diff --git a/src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx b/src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx index 4694a2e73d5c..7722696245fd 100644 --- a/src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx +++ b/src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx @@ -514,18 +514,18 @@ const SearchReportModalStackNavigator = createModalStackNavigator({ [SCREENS.SEARCH.ADVANCED_FILTERS_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_DATE_RHP]: () => require('../../../../pages/Search/SearchFiltersDatePage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_CURRENCY_RHP]: () => require('../../../../pages/Search/SearchFiltersCurrencyPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_DESCRIPTION_RHP]: () => require('../../../../pages/Search/SearchFiltersDescriptionPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_MERCHANT_RHP]: () => require('../../../../pages/Search/SearchFiltersMerchantPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_REPORT_ID_RHP]: () => require('../../../../pages/Search/SearchFiltersReportIDPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_AMOUNT_RHP]: () => require('../../../../pages/Search/SearchFiltersAmountPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_CATEGORY_RHP]: () => require('../../../../pages/Search/SearchFiltersCategoryPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_KEYWORD_RHP]: () => require('../../../../pages/Search/SearchFiltersKeywordPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_CARD_RHP]: () => require('../../../../pages/Search/SearchFiltersCardPage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_TAX_RATE_RHP]: () => require('../../../../pages/Search/SearchFiltersTaxRatePage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_EXPENSE_TYPE_RHP]: () => require('../../../../pages/Search/SearchFiltersExpenseTypePage').default, - [SCREENS.SEARCH.ADVANCED_FILTERS_TAG_RHP]: () => require('../../../../pages/Search/SearchFiltersTagPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_DATE_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersDatePage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_CURRENCY_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersCurrencyPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_DESCRIPTION_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersDescriptionPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_MERCHANT_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersMerchantPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_REPORT_ID_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersReportIDPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_AMOUNT_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersAmountPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_CATEGORY_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_KEYWORD_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersKeywordPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_CARD_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_TAX_RATE_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersTaxRatePage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_EXPENSE_TYPE_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage').default, + [SCREENS.SEARCH.ADVANCED_FILTERS_TAG_RHP]: () => require('../../../../pages/Search/SearchAdvancedFiltersPage/SearchFiltersTagPage').default, [SCREENS.SEARCH.ADVANCED_FILTERS_FROM_RHP]: () => require('@pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage').default, [SCREENS.SEARCH.ADVANCED_FILTERS_TO_RHP]: () => require('@pages/Search/SearchAdvancedFiltersPage/SearchFiltersToPage').default, }); diff --git a/src/pages/Search/SearchFiltersAmountPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAmountPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersAmountPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAmountPage.tsx diff --git a/src/pages/Search/SearchFiltersCardPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersCardPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx diff --git a/src/pages/Search/SearchFiltersCategoryPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersCategoryPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx diff --git a/src/pages/Search/SearchFiltersCurrencyPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCurrencyPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersCurrencyPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCurrencyPage.tsx diff --git a/src/pages/Search/SearchFiltersDatePage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersDatePage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersDatePage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersDatePage.tsx diff --git a/src/pages/Search/SearchFiltersDescriptionPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersDescriptionPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersDescriptionPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersDescriptionPage.tsx diff --git a/src/pages/Search/SearchFiltersExpenseTypePage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersExpenseTypePage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExpenseTypePage.tsx diff --git a/src/pages/Search/SearchFiltersKeywordPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersKeywordPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersKeywordPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersKeywordPage.tsx diff --git a/src/pages/Search/SearchFiltersMerchantPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersMerchantPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersMerchantPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersMerchantPage.tsx diff --git a/src/pages/Search/SearchFiltersReportIDPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersReportIDPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersReportIDPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersReportIDPage.tsx diff --git a/src/pages/Search/SearchFiltersTagPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTagPage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersTagPage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTagPage.tsx diff --git a/src/pages/Search/SearchFiltersTaxRatePage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx similarity index 100% rename from src/pages/Search/SearchFiltersTaxRatePage.tsx rename to src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx