From c79df43a9de0ed7888ccc5498b5282587c43e040 Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Thu, 26 Jan 2023 14:38:41 +0000 Subject: [PATCH 1/7] Update CONTRIBUTING.md Pulling now, but will add link to best practices once done --- contributingGuides/CONTRIBUTING.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index f4b1520c67c6..6f2a94369239 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -144,6 +144,15 @@ Additionally if you want to discuss an idea with the open source community witho 15. Upon submission of a PR, please include a numbered list of explicit testing steps for each platform (Web, Desktop, iOS, Android, and Mobile Web) to confirm the fix works as expected and there are no regressions. 16. Please add a screenshot of the app running on each platform (Web, Desktop, iOS, Android, Mobile Web). +### Completing the final checklist +17. Once your PR has deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. +18. The items requiring your completion consist of: + 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head here.) + 2. Identifying and noting the offending PR that caused the bug (if any) + 3. Commenting on the offending PR to note the bug it caused and why (if applicable) + 4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again. +20. Once the above items have been successfully completed, then payments will begin to be issued. + #### Timeline expectations and asking for help along the way - If you have made a change to your pull request and are ready for another review, leave a comment that says "Updated" on the pull request itself. - Please keep the conversation in GitHub, and do not ping individual reviewers in Slack or Upwork to get their attention. From eac770a1fb3a88275b47f1635d1856d881573173 Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Fri, 27 Jan 2023 10:29:51 +0000 Subject: [PATCH 2/7] Update contributingGuides/CONTRIBUTING.md Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index 6f2a94369239..22e89eb3184b 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -144,7 +144,7 @@ Additionally if you want to discuss an idea with the open source community witho 15. Upon submission of a PR, please include a numbered list of explicit testing steps for each platform (Web, Desktop, iOS, Android, and Mobile Web) to confirm the fix works as expected and there are no regressions. 16. Please add a screenshot of the app running on each platform (Web, Desktop, iOS, Android, Mobile Web). -### Completing the final checklist +#### Completing the final checklist 17. Once your PR has deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. 18. The items requiring your completion consist of: 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head here.) From 1e90ed48ad0a83ba3ad0e3f02b85cb0776d01d34 Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Fri, 27 Jan 2023 10:30:01 +0000 Subject: [PATCH 3/7] Update contributingGuides/CONTRIBUTING.md Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index 22e89eb3184b..47ec2744001a 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -145,7 +145,7 @@ Additionally if you want to discuss an idea with the open source community witho 16. Please add a screenshot of the app running on each platform (Web, Desktop, iOS, Android, Mobile Web). #### Completing the final checklist -17. Once your PR has deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. +17. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. 18. The items requiring your completion consist of: 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head here.) 2. Identifying and noting the offending PR that caused the bug (if any) From 3dc33a29ff576047b88bc2cbda6c3edcab0271d9 Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Fri, 27 Jan 2023 10:31:57 +0000 Subject: [PATCH 4/7] Update CONTRIBUTING.md adding link --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index 47ec2744001a..ab828261a310 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -147,7 +147,7 @@ Additionally if you want to discuss an idea with the open source community witho #### Completing the final checklist 17. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. 18. The items requiring your completion consist of: - 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head here.) + 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md).) 2. Identifying and noting the offending PR that caused the bug (if any) 3. Commenting on the offending PR to note the bug it caused and why (if applicable) 4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again. From b60cea8e77bcb61346714dd5e2550fc0ad110fca Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:18:22 +0000 Subject: [PATCH 5/7] Update contributingGuides/CONTRIBUTING.md Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index ab828261a310..2c359e848020 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -149,7 +149,7 @@ Additionally if you want to discuss an idea with the open source community witho 18. The items requiring your completion consist of: 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md).) 2. Identifying and noting the offending PR that caused the bug (if any) - 3. Commenting on the offending PR to note the bug it caused and why (if applicable) + 3. Commenting on the offending PR to note the bug it caused and why (if applicable). 4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again. 20. Once the above items have been successfully completed, then payments will begin to be issued. From 9505a95fd30ba54bc061357c9c7d3c18b338a98e Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:18:27 +0000 Subject: [PATCH 6/7] Update contributingGuides/CONTRIBUTING.md Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index 2c359e848020..84a49e0f4ff2 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -148,7 +148,7 @@ Additionally if you want to discuss an idea with the open source community witho 17. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. 18. The items requiring your completion consist of: 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md).) - 2. Identifying and noting the offending PR that caused the bug (if any) + 2. Identifying and noting the offending PR that caused the bug (if any). 3. Commenting on the offending PR to note the bug it caused and why (if applicable). 4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again. 20. Once the above items have been successfully completed, then payments will begin to be issued. From 82ed2fba2aa46de8aec75ad7a9fd9ae127c16811 Mon Sep 17 00:00:00 2001 From: Dylan Courtney <60117248+dylanexpensify@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:18:33 +0000 Subject: [PATCH 7/7] Update contributingGuides/CONTRIBUTING.md Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index 84a49e0f4ff2..dc531040812e 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -147,7 +147,7 @@ Additionally if you want to discuss an idea with the open source community witho #### Completing the final checklist 17. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued. 18. The items requiring your completion consist of: - 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md).) + 1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md)). 2. Identifying and noting the offending PR that caused the bug (if any). 3. Commenting on the offending PR to note the bug it caused and why (if applicable). 4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again.