From 0fa4c3ed75cd0507f96a745a067c362cbddb446c Mon Sep 17 00:00:00 2001 From: rory Date: Tue, 12 Sep 2023 10:26:44 +0800 Subject: [PATCH 1/2] Fix deploy checklist --- .github/workflows/platformDeploy.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index a98381b0f4a7..a9328d6b9011 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -32,6 +32,7 @@ jobs: deployChecklist: name: Create or update deploy checklist runs-on: ubuntu-latest + if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }} needs: validateActor steps: - uses: actions/checkout@v3 @@ -39,7 +40,7 @@ jobs: - name: Set version id: getVersion - run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV" + run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_OUTPUT" - name: Create or update staging deploy uses: Expensify/App/.github/actions/javascript/createOrUpdateStagingDeploy@main From 5e09ff8044625463ce721954ebd06c750af61bc2 Mon Sep 17 00:00:00 2001 From: rory Date: Tue, 12 Sep 2023 10:37:18 +0800 Subject: [PATCH 2/2] Don't use env in job-level if --- .github/workflows/platformDeploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index a9328d6b9011..cd65b8451636 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -32,7 +32,7 @@ jobs: deployChecklist: name: Create or update deploy checklist runs-on: ubuntu-latest - if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }} + if: ${{ github.event_name != 'release' }} needs: validateActor steps: - uses: actions/checkout@v3