diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 78ab69af544b..05c2e2b441fb 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,14 +1,14 @@ name: Lint JavaScript on: - workflow_dispatch: + workflow_call: pull_request: types: [opened, synchronize] branches-ignore: [staging, production] jobs: lint: - if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_dispatch' }} + if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/preDeploy.yml b/.github/workflows/preDeploy.yml index 266f998d4f03..363c0f619b28 100644 --- a/.github/workflows/preDeploy.yml +++ b/.github/workflows/preDeploy.yml @@ -5,24 +5,18 @@ on: branches: [main] jobs: + lint: + uses: ./.github/workflows/lint.yml + + test: + uses: ./.github/workflows/test.yml + confirmPassingBuild: runs-on: ubuntu-latest + needs: [lint, test] + if: ${{ always() && (needs.lint.result == 'failure' || needs.test.result == 'failure') }} steps: - - name: Run lint - id: lint - uses: Expensify/App/.github/actions/triggerWorkflowAndWait@main - with: - WORKFLOW: lint.yml - GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} - - - name: Run tests - id: tests - uses: Expensify/App/.github/actions/triggerWorkflowAndWait@main - with: - WORKFLOW: test.yml - GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} - # This Slack step is duplicated in all workflows, if you make a change to this step, make sure to update all # the other workflows with the same change - uses: 8398a7/action-slack@v3 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c60b20a2257a..ea730c100996 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,14 +1,14 @@ name: Jest Unit Tests on: - workflow_dispatch: + workflow_call: pull_request: types: [opened, synchronize] branches-ignore: [staging, production] jobs: test: - if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_dispatch' }} + if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2