-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-11-29] [$2000][Image] Attachments uploaded via camera lose their rotation, appears sideways. #11854
Comments
Triggered auto assignment to @arielgreen ( |
@arielgreen I'm going to take this one from you if you don't mind! 😄 |
Having trouble accessing Upwork at the moment, though I'll get to this one asap. |
Actually I'm getting ahead of myself. I think this should be external but I'll quickly confirm with an Engineer to ensure that others agree. |
Triggered auto assignment to @NikkiWines ( |
@NikkiWines I imagine we can look for the orientation someone in the image metadata, so it's simply a matter of making sure we respect that orientation post upload. Do you agree? |
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Triggered auto assignment to @mountiny ( |
Sorry that must have been fat-fingering, still waiting for @hellohublot for the PR. Feel free to link a draft as well 🙌 |
Huh, not sure how to explain that. I've gone ahead and sent an offer to @sobitneupane since we've worked together before. @hellohublot to make sure we hire the right profile in Upwork, can you apply here: https://www.upwork.com/jobs/~01a08d6a4623670c83. |
@mountiny Yes, I have. |
@hellohublot It has been two days now without linked PR, can you please link a draft PR to show the progress. Or update us on why you havent been able to start the PR yet. Thank you very much! |
@mountiny |
@hellohublot I think unit tests are not required here unless this would be easy to achieve, not sure how one does unit tests about taking a picture. We will add a regression test specifically for this so QA will always check the camera features work as expected. |
Hi. I have created a PR: #12765, please help me to check, Thanks |
PR is in a review. |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The offending PR has been this #10297, which has bumped the version f the library with upstream fix for different issue but the solution has introduced this bug in the package. |
@hellohublot - quick bump on this please to apply to the job on Upwork so we're ready to issue payment. |
@trjExpensify OK, I have submitted it on upwork, my username is also hellohublot, Thanks |
I can't see that on this upwork job, are you sure you sent it on the right one? |
@trjExpensify https://www.upwork.com/freelancers/~01509ca2c74bfc7073 |
Thanks, but can you click this link and apply to the job? When I search for your profile, I can't find you. |
@trjExpensify |
@trjExpensify Maybe you can try to search "hublot", if you still can't find me, maybe this job can only hire one person, please help to try to create another job, Thanks |
Okay, payment is due today. @hellohublot you've been hired for another job since, so I've been able to locate you via that. Not sure why your application for this one hasn't been received - but I've sent you an offer. I've also applied the 50% bonus for merging the PR within 3 days. @sobitneupane - settled up for C+ 👍 |
As for the checklist:
|
Cool, I've now settled up with @hellohublot. Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Uploaded image should be in the same orientation
Actual Result:
All uploaded photos lose their orientation and are rotated 90 degrees to the left
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.15-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/195900439-cb259355-2f1b-45a5-bf87-3096a4b86252.MP4
![](https://user-images.githubusercontent.com/43996225/195900590-5429ba0d-a59b-4258-aafd-68c8f29f8435.PNG)
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665704504033759
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: