[HOLD for payment 2023-02-07] Not opening plaid screen when user click on connect online with plaid

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. create a new workspace
2. click on connect back account
3. wait for complete the loading
4. again create a new workspace
5. immediate click on connect back account
6. click on connect online with plaid option

Expected Result:

should open plaid screen

Actual Result:

not opening plaid screen

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-01-20.at.12.23.33.PM.mov

Recording.1377.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674198664819569

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014365699878ee35c6
• Upwork Job ID: 1618912244890304512
• Last Price Increase: 2023-01-27

[trjExpensify]

v1.2.60-0 Web MacOS Chrome:

There does seems to be a long delay when trying to connect with Plaid in quick succession after creating a workspace, so I wonder if there's a performance regression here somewhere?

@MariaHCD @nkuoch @ctkochan22 can this go external or would it need to be an internal investigation?

[trjExpensify]

Same on MacOS Safari for good measure:

[MariaHCD]

Hmm...this was fixed here: #14505

And I can't seem to reproduce on staging v1.2.60-0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014365699878ee35c6

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[trjExpensify]

Ah cool, looks like @nkuoch has figured it out? Nice!

[nkuoch]

I'm adding a fix so we don't show the buttons when they are not ready to be clicked on (adding the loader right when opening the page). But there might be another issue with the CreateWorkspace call which seems to take quite long (which I'm not investigating).

[MariaHCD]

But there might be another issue with the CreateWorkspace call which seems to take quite long

Ah, interesting. Could you expand on this? I've been looking into why CreateWorkspace command takes too long here. Haven't been able to find anything conclusive just yet but will continue digging.

[nkuoch]

I haven't investigated that one, I just noticed it was the reason the optimisticData to open the reimbursement page happened later (because there was this long call of CreateWorkspace not finished in the queue)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.62-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add reimbursementpage loader right away #14619

If no regressions arise, payment will be issued on 2023-02-07. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav / @nkuoch] The PR that introduced the bug has been identified. Link to the PR: N/A - The bug could also be reproduced from the start, in some edge cases
• [@0xmiroslav / @nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@0xmiroslav / @nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@trjExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://expensify.testrail.io/index.php?/cases/view/1971065&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229065

[trjExpensify]

👋 @0xmiroslav I sent you the $1k offer for the internal PR review and @gadhiyamanan $250 for the bug report. Let me know when you get a sec to accept and I'll issue the payments.

[@trjExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

For this, we already have a test script for it and the page not loading should be caught within that, so no changes to make. Specifically thinking about the first few steps here:

1. Navigate to the add bank account modal in Workspace settings
2. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
3. Click/tap on the Log in method
4. Verify the loading spinner appears vertically centred and then the plaid modal is displayed.
5. Select Chase bank

That will fail if the Plaid modal doesn't open correctly.

[gadhiyamanan]

@trjExpensify accepted

[trjExpensify]

Paid! Over to you @0xmiroslav to accept :)

[trjExpensify]

Awesome, everyone is paid. Thanks!