Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-21] Use the same component for the different states in ValidateCodeModal #16424

Closed
cristipaval opened this issue Mar 22, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff

Comments

@cristipaval
Copy link
Contributor

cristipaval commented Mar 22, 2023

Coming from this.
Refactor the code in ValidateCodeModal package and reuse the same component for multiple states to avoid code duplication.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012154682b55de640e
  • Upwork Job ID: 1638643992224706560
  • Last Price Increase: 2023-03-22
@cristipaval cristipaval added Engineering Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Mar 22, 2023
@cristipaval cristipaval self-assigned this Mar 22, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~012154682b55de640e

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

@cristipaval
Copy link
Contributor Author

cristipaval commented Mar 27, 2023

Making this a weekly, I'll do my best to get it done at the end of the week as this could also be implemented on the plane

@melvin-bot melvin-bot bot removed the Overdue label Mar 27, 2023
@cristipaval cristipaval added Weekly KSv2 and removed Daily KSv2 labels Mar 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 4, 2023
@cristipaval
Copy link
Contributor Author

on my radar for the next days

@melvin-bot melvin-bot bot removed the Overdue label Apr 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 13, 2023
@cristipaval cristipaval changed the title Use the same component for the different states in ValidateCodeModal [HOLD App #16214] Use the same component for the different states in ValidateCodeModal Apr 18, 2023
@cristipaval
Copy link
Contributor Author

on hold for now. It's better to first migrate the ValidateCodeModal to the function component

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2023
@cristipaval
Copy link
Contributor Author

Oh yes this could be off hold now.

@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2023
@cristipaval cristipaval changed the title [HOLD App #16214] Use the same component for the different states in ValidateCodeModal Use the same component for the different states in ValidateCodeModal Apr 27, 2023
@melvin-bot melvin-bot bot added the Overdue label May 5, 2023
@cristipaval cristipaval added Monthly KSv2 and removed Weekly KSv2 labels May 8, 2023
@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@cristipaval
Copy link
Contributor Author

cristipaval commented May 8, 2023

Making this Monthly since it isn't a high priority. Still want to work on it, the thing is that I am currently focused on some other things with higher priority.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jun 7, 2023
@melvin-bot melvin-bot bot changed the title Use the same component for the different states in ValidateCodeModal [HOLD for payment 2023-06-21] Use the same component for the different states in ValidateCodeModal Jun 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 21, 2023
@cristipaval
Copy link
Contributor Author

Hmm.. it looks like no BugZero team member was assigned. Asked for help on Slack

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 29, 2023

@cristipaval, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cristipaval
Copy link
Contributor Author

bumped BugZero team in Slack to handle the payment

@melvin-bot melvin-bot bot removed the Overdue label Jun 29, 2023
@kadiealexander kadiealexander self-assigned this Jun 29, 2023
@anmurali
Copy link

anmurali commented Jul 1, 2023

Paid Sobit on New Dot

@kadiealexander
Copy link
Contributor

Closing as Sobit was paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants