Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hold for payment 2023-04-19] Payment issue for E/App PR#16734 #17224

Closed
melvin-bot bot opened this issue Apr 10, 2023 · 13 comments
Closed

[hold for payment 2023-04-19] Payment issue for E/App PR#16734 #17224

melvin-bot bot opened this issue Apr 10, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Apr 10, 2023

Issue created to compensate the Contributor+ member for their work on #16734
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/270488.
Contributor+ member who reviewed the PR - @aimane-chnaif.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f0af227f1ca94ec9
  • Upwork Job ID: 1645475325954871296
  • Last Price Increase: 2023-04-10
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Apr 10, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Apr 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01f0af227f1ca94ec9

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 10, 2023
@MelvinBot
Copy link

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

@MelvinBot
Copy link

MelvinBot commented Apr 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@joekaufmanexpensify
Copy link
Contributor

Changing to weekly for now as the PR is still in review.

@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 10, 2023
@joekaufmanexpensify
Copy link
Contributor

PR is out to prod as of 2023-04-12. We'll issue payment after 7 day regression period on 2023-04-19.

@joekaufmanexpensify joekaufmanexpensify changed the title Payment issue for E/App PR#16734 [hold for payment 2023-04-19] Payment issue for E/App PR#16734 Apr 14, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 17, 2023
@joekaufmanexpensify
Copy link
Contributor

Still pending payment in 2 days

@joekaufmanexpensify
Copy link
Contributor

same

@joekaufmanexpensify
Copy link
Contributor

@aimane-chnaif offer sent for $1,000!

@joekaufmanexpensify
Copy link
Contributor

We hit 7 days today with no regressions, issuing payment!

@joekaufmanexpensify
Copy link
Contributor

@aimane-chnaif $1,000 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants