[HOLD for payment 2023-06-21] [$1000] Web - Room - Visibility subtitle is wrong for public room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on + icon
2. Choose new room option
3. Enter room name
4. Choose visibility as public and check subtitle below the dropdown (Anyone can find this room)
5. Click on create room button
6. Go to room
7. Click on header to see Details
8. Go to Settings and check text in Visibility section

Expected Result:

For public room text should be Anyone can find this room

Actual Result:

Wrong text shows(People invited to this room can find it)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.23.6

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-31.at.3.09.31.PM.mov

Recording.2963.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685526019865179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01005cb0382b9b4e71
• Upwork Job ID: 1666314654139772928
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visibility subtitle is wrong for public room

What is the root cause of that problem?

no condition added for public room description

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 204 to 208 in efb1463

	<Text style={[styles.textLabelSupporting, styles.mt1]}>
	{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
	? this.props.translate('newRoomPage.restrictedDescription')
	: this.props.translate('newRoomPage.privateDescription')}
	</Text>

What changes do you think we should make in order to solve the problem?

use {this.props.translate(`newRoomPage.${this.props.report.visibility}Description`)} instead of below condition same as WorkspaceNewRoomPage.js

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 204 to 208 in efb1463

	<Text style={[styles.textLabelSupporting, styles.mt1]}>
	{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
	? this.props.translate('newRoomPage.restrictedDescription')
	: this.props.translate('newRoomPage.privateDescription')}
	</Text>

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Yeah, I'm able to reproduce this one. Opening it up for proposal/reviews

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01005cb0382b9b4e71

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @madmax330 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tungmt]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visibility description is wrong for public room.

What is the root cause of that problem?

Current visibility description only either restricted or private.

<Text style={[styles.textLabelSupporting, styles.mt1]}>
        p.{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
           ? this.props.translate('newRoomPage.restrictedDescription')
           : this.props.translate('newRoomPage.privateDescription')}
</Text>

What changes do you think we should make in order to solve the problem?

Solution 1: Use switch to get the correct description

visibilityDescription(visibility) {
        switch (visibility) {
            case CONST.REPORT.VISIBILITY.RESTRICTED:
                return this.props.translate('newRoomPage.restrictedDescription');
            case CONST.REPORT.VISIBILITY.PRIVATE:
                return this.props.translate('newRoomPage.privateDescription');
            default:
                return this.props.translate('newRoomPage.publicDescription');
        }
    }

<Text style={[styles.textLabelSupporting, styles.mt1]}>
     {this.visibilityDescription(this.props.report.visibility)}
</Text>

Solution 2: Use one more check condition

<Text style={[styles.textLabelSupporting, styles.mt1]}>
        {this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
                  ? this.props.translate('newRoomPage.restrictedDescription')
                     : (this.props.report.visibility === CONST.REPORT.VISIBILITY.PRIVATE ?
                               this.props.translate('newRoomPage.privateDescription')
                               : this.props.translate('newRoomPage.publicDescription')
                       )
       }
</Text>

What alternative solutions did you explore? (Optional)

[WikusKriek]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The report settings page only caters for two visibility scenarios

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 202 to 206 in 9ab54c2

	<Text style={[styles.textLabelSupporting, styles.mt1]}>
	{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
	? this.props.translate('newRoomPage.restrictedDescription')
	: this.props.translate('newRoomPage.privateDescription')}
	</Text>

there are four

App/src/CONST.js

Lines 610 to 615 in 9ab54c2

	VISIBILITY: {
	PUBLIC: 'public',
	PUBLIC_ANNOUNCE: 'public_announce',
	PRIVATE: 'private',
	RESTRICTED: 'restricted',
	},

What changes

We need to add conditions for all four checks and display the correct translated text.

What alternative solutions did you explore? (Optional)

N/A

[maxim-abuzarov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visibility subtitle is wrong for public room

What is the root cause of that problem?

There are no condition added for public room description.

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 202 to 206 in 79f18ec

	<Text style={[styles.textLabelSupporting, styles.mt1]}>
	{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
	? this.props.translate('newRoomPage.restrictedDescription')
	: this.props.translate('newRoomPage.privateDescription')}
	</Text>

What changes do you think we should make in order to solve the problem?

The easiest way is to change

{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED 
         ? this.props.translate('newRoomPage.restrictedDescription') 
         : this.props.translate('newRoomPage.privateDescription')} 

to
{this.props.translate(`newRoomPage.${this.props.report.visibility}Description`)}

[melvin-bot]

📣 @maxim-abuzarov! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[maxim-abuzarov]

Contributor details
Your Expensify account email: maksim.abuzarov@yandex.ru
Upwork Profile Link: https://www.upwork.com/freelancers/~01697caeeda3411355

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[JmillsExpensify]

@abdulrahuman5196 thoughts on these proposals?

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@JmillsExpensify Thank you for checking up.

@gadhiyamanan's proposal here #20127 (comment) looks good. All other proposals present here are the same with minor variations so choosing the first proposal.

🎀👀🎀
C+ Reviewed

cc: @madmax330

[JmillsExpensify]

Ok great, thanks! @madmax330 You good with this approach? If so, let's get the contributor assigned and put this in motion. 🙌🏼

[madmax330]

Yeah looks good to me

[melvin-bot]

📣 @gadhiyamanan You have been assigned to this job by @madmax330!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[gadhiyamanan]

@abdulrahuman5196 @madmax330 PR is ready for review

[melvin-bot]

🎯 ⚡️ Woah @abdulrahuman5196 / @gadhiyamanan, great job pushing this forwards! ⚡️

The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @gadhiyamanan got assigned: 2023-06-09 06:23:53 Z
• when the PR got merged: 2023-06-09 12:16:20 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix room visibility description #20500

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

BZ checklist

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Doesn't seem to be regression. It seems to be a miss from the original page implementation itself and we haven't noticed before the bug report - #16910

Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. I don't think a regression test would be beneficial for this minor issue.

[abdulrahuman5196]

Gentle ping on payment processing for this issue @JmillsExpensify

[madmax330]

bump @JmillsExpensify

[JmillsExpensify]

Thanks for your patience, summarizing payouts for this issue:

• Issue reporter: @gadhiyamanan $250
• Contributor: @gadhiyamanan $1,500
• Contributor+: @abdulrahuman5196 $1,500

Upwork job is here. I'll issue bonus on final payout.

[gadhiyamanan]

@JmillsExpensify accepted, thanks!

[abdulrahuman5196]

Thank you @JmillsExpensify. Accepted the upwork offer.

[JmillsExpensify]

Awesome, everyone is paid out at this point.

[JmillsExpensify]

Closing this, please comment if anything is outstanding.