-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-03] [$1000] IOU has pin option in LHN #20255
Comments
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The LHN context menu allows the user to pin IOU threads. What is the root cause of that problem?As per #19438 (comment), IOU reports should not have any pin options as they are pinned by default, but the transaction chats should. Whereas this new contextmenu functionality is enabled for all reports What changes do you think we should make in order to solve the problem?We should disable the pin button on the contextmenu for IOU reports. What alternative solutions did you explore? (Optional)None |
I think this is expected behaviour but .... ¯_(ツ)_/¯.
|
There was a discussion about this in #19438 (comment) as far as the pin icon/green light is concerned the current behaviour is expected, the problem here is that there is the option to pin/unpin IOUs from the LHN context menu which shouldn't be there, if you look at the IOU header in the chat it has no pin option. |
I think @trjExpensify might know what the expected behaviour should be here. |
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@Ollyws , good catch. It does make sense that, if the chat isn't pin-able, then we shouldn't show the option. I like that better than allowing pinning I was going to put this on hold pending the below but noticed it hit production a week ago and that worked on the PR for that @Ollyws |
Job added to Upwork: https://www.upwork.com/jobs/~0139b2338fd7598cc2 |
Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Triggered auto assignment to @amyevans ( |
@Ollyws Thanks for the proposal. What if we use |
@parasharrajat I did consider that approach, it would be viable but I thought maybe it would be better to keep it all in getOptionData. |
I don't see why we need to modify any of these functions.
|
@parasharrajat Yes exactly. I meant modify |
Ok, Great. @Ollyws' proposal looks good with #20255 (comment) suggestion as it more tidy. Feedback: @Ollyws Try to break your statement into paragraphs especially when two different problems are being explained. Use Code links that show code directly in the comment. e.g.
cc: @amyevans 🎀 👀 🎀 C+ reviewed |
📣 @Ollyws You have been assigned to this job by @amyevans! |
@Ollyws , @parasharrajat , @Natnael-Guchima hired in Upwork, please accept https://www.upwork.com/jobs/~0139b2338fd7598cc2 |
Accepted. Thanks @mallenexpensify |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
@amyevans, @Ollyws, @mallenexpensify, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-03. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Everyone paid! |
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:#16079 Regression Test Steps
Do you agree 👍 or 👎 ? |
Thanks @parasharrajat , TestRail issue created |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
4. Click on 'Pin' button5. Observe that IOU thread is pinned to the top but that there is no pin icon on the LHN
Expected Result:
Pin option shouldn't show since the IOU/expense report can't be pinned because it has the green dot.
Pin icon should be displayed on LHN when pinning the thread, and the pin icon should be removed when unpinning the threadActual Result:
Pin option is shown.
Pin icon is not displayed when pinning the IOU threadWorkaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.27.0
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
2023-06-03.09.03.46.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685772909333819
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: