[HOLD for payment 2023-10-25] [$1000] The search result still shows emoji for wrong texts

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. On staging web chrome, navigate to a chat and click the emoji on the chat
2. Type in any emoji name (example search) and after you enter the last character ('h' in my case for search), do not release your fingers and continuous type any other letters. You'll see still the emojis are shown. But now release your fingers and see , it displays 'Not found'
3. Repeat the above steps on Slack and you'll see after entering the last character of the emoji, if you type any other letters even without releasing your fingers, it will still show 'Not found'

Expected Result:

The search result should show 'Not found' if the text doesn't match with emoji

Actual Result:

The search result still shows emoji for wrong texts

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.2661.mp4

Recording.2661.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686306616768299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d07f1517b1b1cba9
• Upwork Job ID: 1671998870894948352
• Last Price Increase: 2023-07-06

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The No Results Found message is center aligned.

What is the root cause of that problem?

This issue was reported previously reported and fixed here - #17245

However, the refactor in #18221 reintroduced this issue.

What changes do you think we should make in order to solve the problem?

We need to remove the following lines:

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Line 528 in edf529e

<View style={[styles.alignItemsCenter, styles.justifyContentCenter, styles.flex1]}>

This will ensure that the results show right below the search text. We will need to do the same for the native files as well.

Additionally, we can add the supporting styles as well but that is a matter than can be finalised in the PR.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DanutGavrus]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The search result still shows emoji for wrong texts.

What is the root cause of that problem?

Right now, in EmojiPickerMenu we have this:

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Line 73 in bd0e843

this.filterEmojis = _.debounce(this.filterEmojis.bind(this), 300);

The debounce method makes the emoji picker seem slow(as seen in a video in the next section).

The filter was initially added in this commit with no debounce at all. The debounce was later added in this commit with a value of 500, which was then reduced to 300 and remained unchanged from April 2021.

What changes do you think we should make in order to solve the problem?

The filter method makes no network call and it executes very fast, so I would suggest to remove the debounce at all. If, for some reason, we need to keep the debounce, I would suggest to lower the value to the smallest one possible in order to make the picker as fast as we can.

We also need to keep both index and index.native.js in sync, so we need to make the same change in both files.

I've made 2 videos for comparison:

Picker with 300 debounce:

300_debounce.mp4

*NOTE: if you keep typing forever in the previous video, you will still see the emojis forever. It's when you stop typing that you see the "No results found." message eventually.

Picker with no debounce:

no_debounce.mp4

I've also played with small values for the debounce, up to 50 I could not reproduce the bug, no matter how fast I was typing. At 100 it's reproducible, but not as easy as it's now. We may discuss if we want to remove it completely, or to just lower it to 50(or other value).

[sophiepintoraetz]

Reassigning because Kadie is OOO and this shouldn't have hit her K2 (timezone takes a while to catch up with 0%!)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d07f1517b1b1cba9

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[mallenexpensify]

@aimane-chnaif can you please review the proposals above, thx

[kadiealexander]

Thanks for keeping this warm, Matt!

[melvin-bot]

This issue has not been updated in over 15 days. @stitesExpensify, @perunt, @kadiealexander, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Search throttle for emoji picker web #23846

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @perunt does not require payment (Contractor)
• @aimane-chnaif requires payment
• @avi-shek-jha requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Payouts due:

• Issue Reporter: $250 @avi-shek-jha
• Contributor+: $1000 @aimane-chnaif

Eligible for 50% #urgency bonus? No

Upwork job is here.

[aimane-chnaif]

I think original base price applies here. PR was raised before announcement.

[aimane-chnaif]

@kadiealexander I already have offer accepted long time ago. #21055 (comment)

[kadiealexander]

@aimane-chnaif I cannot access that contract anymore could you please link it here? Could you also please complete the BugZero checklist?

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This is not bug but a bit improvement. No need regression test.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[kadiealexander]

@aimane-chnaif please don't forget to link your offer!

[aimane-chnaif]

@kadiealexander I am also not able to find that contract. Sorry for confusion. Can you please send offer again?

[kadiealexander]

Sent!

[kadiealexander]

@aimane-chnaif bump to accept the Upwork contract.

[aimane-chnaif]

@kadiealexander accepted thanks