Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms #21495

Closed
1 of 6 tasks
kbecciv opened this issue Jun 24, 2023 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Jun 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to '+" -> new room
  2. Type in room name -> add workspace
  3. (IMPORTANT STEP) make room as public
  4. Now on room page, on room chat, type '@' and mention some contact number ( WORKS WELL WITH EMAILS)
    for eg . i did mentioned @+9779866****** phone number
  5. Notice that it is flagged automatically

Expected Result:

Contact numbers should not be flagged as a violation of rule, as in real we might need to mention some user ( which has signed up using phone number)

Actual Result:

Contact numbers are flagged as violation while mentioning in public rooms

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.32.5

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-24.at.8.35.20.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @ashimsharma10

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687619050679359

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0108e1fd1f5b114d4b
  • Upwork Job ID: 1673384510798495744
  • Last Price Increase: 2023-06-26
@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment Needs Reproduction Reproducible steps needed labels Jun 24, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 24, 2023

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@ashimsharma10
Copy link

@stitesExpensify

@thienlnam
Copy link
Contributor

Stites is OOO, will take this up

@melvin-bot melvin-bot bot added the Overdue label Jun 26, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2023
@thienlnam
Copy link
Contributor

Ah, this would be related to the spam prompt and should be happening on staging and production. Going to remove the blocker and add as an example to https://github.com/Expensify/Expensify/issues/292287

@thienlnam thienlnam added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0108e1fd1f5b114d4b

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@thienlnam thienlnam changed the title Dev: Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms Jun 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 28, 2023
@thienlnam
Copy link
Contributor

Haven't updated this yet - planning with rest of AgentZero updates

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2023
@thienlnam thienlnam removed the Needs Reproduction Reproducible steps needed label Jun 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2023
@thienlnam
Copy link
Contributor

Same as above

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2023
@thienlnam
Copy link
Contributor

Haven't gotten around to this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 6, 2023
@thienlnam
Copy link
Contributor

Same - hoping to this week

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

@thienlnam 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@thienlnam
Copy link
Contributor

Have an internal PR up

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Jul 20, 2023
@thienlnam thienlnam changed the title Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms [HOLD 38223] Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms Jul 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 28, 2023
@thienlnam thienlnam changed the title [HOLD 38223] Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms Contact/Phone numbers ( NOT emails ) are flagged as violation while mentioning in public rooms Aug 1, 2023
@thienlnam
Copy link
Contributor

This should be live now - checking if this is resolved

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2023
@thienlnam
Copy link
Contributor

Screenshot 2023-08-01 at 11 49 19 AM

Looks like this is resolved now - just to pay out bug reporter

@thienlnam thienlnam added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 1, 2023
@melvin-bot

This comment was marked as resolved.

@thienlnam
Copy link
Contributor

cc @tjferriss

I resolved this bug internally, could we get a payout for the bug reporter?
Issue reported by: @ashimsharma10

@tjferriss
Copy link
Contributor

@ashimsharma10 I just sent you an offer via Upworks https://www.upwork.com/jobs/~0158147e2a0ebeea58

@ashimsharma10
Copy link

@tjferriss Have accepted.

@tjferriss
Copy link
Contributor

The payment has been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants