Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-25] [ECard Transactions] Update MoneyReportView UI #28831

Closed
grgia opened this issue Oct 4, 2023 · 17 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Oct 4, 2023

Design Doc Section

https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.814c36x8plt

Overview

Image

Goal:
Update our Money Report Headers to separate out Company and Out-Of-Pocket spend.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3
  • Upwork Job ID: 1709591085181034496
  • Last Price Increase: 2023-10-04
@grgia grgia self-assigned this Oct 4, 2023
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@grgia grgia added the NewFeature Something to build that is a new item. label Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 4, 2023
@grgia grgia added Reviewing Has a PR in review and removed Reviewing Has a PR in review labels Oct 12, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 12, 2023

I think this is the last one I need to do for the core UI, will try to get a PR up in the morning to wrap the major FE up

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 13, 2023
@melvin-bot melvin-bot bot changed the title [ECard Transactions] Update MoneyReportView UI [HOLD for payment 2023-10-25] [ECard Transactions] Update MoneyReportView UI Oct 18, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@s77rt
Copy link
Contributor

s77rt commented Oct 19, 2023

@grgia Do we need a regression test here? I'm not sure what would be the test steps from the user/qa perspective to reproduce this

@lschurr
Copy link
Contributor

lschurr commented Oct 25, 2023

Payment summary:

Contributor+: @s77rt $500

@lschurr
Copy link
Contributor

lschurr commented Oct 25, 2023

@s77rt remind me - are you paid via Newdot or Upwork?

@s77rt
Copy link
Contributor

s77rt commented Oct 25, 2023

@lschurr Upwork

@lschurr
Copy link
Contributor

lschurr commented Oct 25, 2023

Great! Are you able to apply here @s77rt? https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3

@s77rt
Copy link
Contributor

s77rt commented Oct 25, 2023

@lschurr Applied! Thanks!

@lschurr
Copy link
Contributor

lschurr commented Oct 25, 2023

Offer sent @s77rt!

@s77rt
Copy link
Contributor

s77rt commented Oct 25, 2023

Accepted!

@lschurr
Copy link
Contributor

lschurr commented Oct 25, 2023

Great! Paid. Closing.

@lschurr lschurr closed this as completed Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

3 participants