Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed
57 tasks done
OSBotify opened this issue Oct 5, 2023 · 9 comments
Closed
57 tasks done

Deploy Checklist: New Expensify 2023-10-05 #28883

OSBotify opened this issue Oct 5, 2023 · 9 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

Release Version: 1.3.78-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny mountiny added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Daily KSv2 labels Oct 5, 2023
@mountiny mountiny self-assigned this Oct 5, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Oct 5, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.78-0 🚀

@mountiny
Copy link
Contributor

mountiny commented Oct 5, 2023

#28911 demoted to normal bug
#28909 fixed in staging with this CP PR #28890

@kavimuru
Copy link

kavimuru commented Oct 5, 2023

Regression TR is at 50%. We are validating few PRs
#28677 failing with #28921

@kavimuru
Copy link

kavimuru commented Oct 5, 2023

Regression is only 8% left.
#28677 failing with #28921

@mountiny
Copy link
Contributor

mountiny commented Oct 5, 2023

#28919 fixed in staging

@mvtglobally
Copy link

Regression is completed

One open blocker : #28971

unchecked PR:
#28677 failing with #28921

@Beamanator
Copy link
Contributor

I commented in #28921, we should address the bug in the original issue - the PR was a revert so probably didn't cause the bug, the bug existed already - so I'll check off #28677 from the checklist

@Beamanator
Copy link
Contributor

#28971 reproduced in prod, checking it off

Looking into the last 3 checkboxes before deploying!

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants