[HOLD for payment 2023-11-09] [$500] BA - Part of the screen shakes when entering an address offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com or open Desktop or iOS or Android App
2. Login with expensifail account
3. Create new or go to existing workspace
4. Go to Workspace > Bank Account
5. Select any connection option
6. Follow the flow until 'Company information' and 'Personal Information' pages
7. Go Offline
8. Enter address in 'Company address' line on 'Company information' page
9. Enter address in 'Personal address' line on 'Personal Information' page

Expected Result:

The user enters the address without any visible errors

Actual Result:

Part of the screen under address line shakes when entering an address offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79.3

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6227938_1696617516574.Desktop-Offline-Address-Input-Screen-Shakes.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016fd62647afbb5093
• Upwork Job ID: 1710372606170464256
• Last Price Increase: 2023-10-06
• Automatic offers:
• mollfpr | Reviewer | 27097586
• shubham1206agra | Contributor | 27097587

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016fd62647afbb5093

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[izarutskaya]

Not reproduced in Prod

20231007_021853.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

Well this is odd, I am unable to repro this. Can someone else repro this?
cc @CortneyOfstad @marcochavezf @mollfpr

Screen.Recording.2023-10-07.at.8.56.47.AM.mov

[tienifr]

@mountiny @marcochavezf I can quickly raise a PR for this deploy blocker if assigned, this comes from this PR

Proposal

Please re-state the problem that we are trying to solve in this issue.

Part of the screen under address line shakes when entering an address offline

What is the root cause of that problem?

In here, we'll show loading indicator after the user types in the search box. There'll be no result due to the user is offline, so the loading indicator will hide immediately. This causes the flickering

What changes do you think we should make in order to solve the problem?

We just need to return null here if the network is currently offline so that the loading will not display.

props.network.isOffline ? null : (<View style={[styles.pv4]}>
    <ActivityIndicator
        color={themeColors.spinner}
        size="small"
    />
</View>)

The same thing is already done for the listEmptyComponent here with the same approach. We can optionally not show the loader if the user is still typing as well, if we want to, by using the same condition as here.

What alternative solutions did you explore? (Optional)

We can create an upstream fix to the react-native-google-places-autocomplete to not show the listLoaderComponent if the user is offline. But I feel like this is something our app should handle and not the responsibility of the library.

[shubham1206agra]

@tienifr I will handle this.

[shubham1206agra]

@mountiny This upstream fix will fix the problem
FaridSafi/react-native-google-places-autocomplete#914

[mollfpr]

@shubham1206agra Is this issue regression from your PR? If yes, then the assigned C+ in the PR should be assign to this issue.

cc @marcochavezf @CortneyOfstad

[shubham1206agra]

Not really a regression
Cause problem is stemming from upstream and not directly related to our problem

[CortneyOfstad]

@mollfpr @shubham1206agra just checking to see where we are at with this — thanks!

[mollfpr]

@CortneyOfstad The PR is merged and it's on QA now.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fixed offline jumping behaviour #29045

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter — no payment needed as it was Applause
• Contributor that fixed the issue — @shubham1206agra to be paid $500 in Upwork as Contributor
• Contributor+ that helped on the issue and/or PR — @mollfpr to be paid $500 in Upwork as C+

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment offer (Reviewer)
• @shubham1206agra requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@mollfpr / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

Payment is set for tomorrow — @mollfpr and @shubham1206agra any update on the checklist above?

[mollfpr]

[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. The fix is on the upstream.

[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open Expensify App
2. Login with any account
3. Create a new or go to an existing workspace
4. Go to Workspace > Bank Account
5. Select any connection option
6. Follow the flow until the 'Company Information' and 'Personal Information' pages
7. Go Offline
8. Enter the address in the 'Company address' line on the 'Company information' page
9. Verify the form is not jumping
10. 👍 or 👎

[mollfpr]

@CortneyOfstad Could you help with the payment summary? Thank you!

[CortneyOfstad]

Had to create a new job posting in Upwork — https://www.upwork.com/jobs/~015d08915af33b19fc

@mollfpr @shubham1206agra I invited both of you to the knew job. Please let me know as soon as you both accept 👍

[mollfpr]

Hi @CortneyOfstad I'll do manual request in NewDot, so I just need the payment summary. Thank you!

[shubham1206agra]

Had to create a new job posting in Upwork — https://www.upwork.com/jobs/~015d08915af33b19fc

@mollfpr @shubham1206agra I invited both of you to the knew job. Please let me know as soon as you both accept 👍

Done

[melvin-bot]

@marcochavezf, @CortneyOfstad, @mollfpr, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@marcochavezf, @CortneyOfstad, @mollfpr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@marcochavezf, @CortneyOfstad, @mollfpr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

Alright @shubham1206agra you have been paid! @mollfpr creating the payment summary now — sorry for the delay!

[CortneyOfstad]

Payment Summary

Contributor that fixed the issue — @shubham1206agra paid $500 in Upwork as Contributor
Contributor+ that helped on the issue and/or PR — @mollfpr to be paid $500 in NewDot as C+

[CortneyOfstad]

Regression test completed here — https://github.com/Expensify/Expensify/issues/336021

[JmillsExpensify]

$500 payment approved for @mollfpr based on summary above.