[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-28] Wallet - After tapping on the debit card number field, an error message appears

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.3.94.0
**Reproducible in staging?:**Y
**Reproducible in production?:**N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Issue found when executing PR #29983

Action Performed:

1. Log in with any expensifail account
2. Go to profile - Setting - Wallet
3. Select Add Bank Account
4. Select Debit card
5. Put Name on "Name on card" field
6. Tap on "Debit card number" field

Expected Result:

No error message appears after tapping on the debit card number field

Actual Result:

After tapping on the debit card number field, an error message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6259476_1698848724874.Screen_Recording_20231101_095251_New_Expensify__1_.mp4

Production:

Screen_Recording_20231101_095251_New.Expensify.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

@kowczarz Are you able to fix this ASAP or should #29983 be reverted?

[tgolen]

@lanitochka17 I am cherry-picking the revert of the offending PR to staging now. Can you please retest this once it is deployed there and see if the deployblocker is resolved?

[kavimuru]

@tgolen sure we will retest.

[Beamanator]

Ready for retest please @kavimuru 🙏

[kavimuru]

@Beamanator Our team validating. Bug is not reproducible in all the platforms but iOS. iOS build (1.3.94-1) is not available yet.

[allroundexperts]

Can someone please assign this issue to me as I reviewed the PR? Thanks!

[Beamanator]

I can confirm this is fixed on iOS build 1.3.94-2! 👍

[melvin-bot]

@JmillsExpensify, @tgolen, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify, @tgolen, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

@allroundexperts do you mind kicking off the BZ checklist as well?

[JmillsExpensify]

In addition, I'd like confirmation as to whether this issue should be subject to a regression penalty?

[allroundexperts]

Regression Test

1. Log in and Go to profile -> Setting -> Wallet
2. Select Add Bank Account
3. Select Debit card
4. Put Name on "Name on card" field
5. Tap on "Debit card number" field

Verify that no error message appears after tapping on the debit card number field.

Do we 👍 or 👎 ?

[JmillsExpensify]

Hmm, I'm starting to think that this might not be needed in TestRail. @tgolen can I get a second opinion?

[JmillsExpensify]

In the meantime, payment summary:

• Issue reporter: N/A
• Contributor: Expert agency
• Contributor+: @allroundexperts $500

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] AddDebitCardPage fixes #31133

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tgolen]

I agree it's a very low-value regression. If there is already an existing regression test for adding a debit card, maybe this could be just one additional verification that the testers verify. If there is no existing regression test, then we probably don't need to add anything.

[tgolen]

@JmillsExpensify @allroundexperts Can we see about getting this one closed out? Looks like there is a final checklist waiting on you.

[JmillsExpensify]

@allroundexperts mind completing the BZ checklist? Once we get that I get can ahead and close and you can request payment in NewDot.

[allroundexperts]

@JmillsExpensify I've already added the regression test above. Rest of the checklist is not applicable here since this was just a revert of a refactor we previously did.

[JmillsExpensify]

Perfect, thanks for confirming. Regression test created

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.