[HOLD for payment 2024-03-13] [HOLD for payment 2024-02-20] [$500] [MEDIUM] Distance - Address is duplicated when dragging one point over an empty point

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat > + > Request money > Distance
2. Click Finish
3. Enter an address and save it
4. Hold and drag the Finish point above the Start point

Expected Result:

The Finish point will become Start point

Actual Result:

The Finish point is duplicated to become Start point
This issue also occurs when dragging Start point with address to below empty Finish point

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331780_1704328200276.20240104_034302.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019049b6059932909e
• Upwork Job ID: 1742713103147515904
• Last Price Increase: 2024-01-04
• Automatic offers:
• tienifr | Contributor | 28081723

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019049b6059932909e

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Finish point is duplicated to become Start point
This issue also occurs when dragging Start point with address to below empty Finish point

What is the root cause of that problem?

In here, we're not clearing the empty waypoint by using removeWaypoint, so when we update in Onyx, it will not override the existing waypoint, leading to duplicate waypoint.

What changes do you think we should make in order to solve the problem?

Use removeWaypoint to remove the empty waypoints when dragging.

More detailed steps:

• Find waypoints that currently is not empty but become empty after the drag
• Use removeWaypoint on them to remove them from Onyx. We can modify the removeWaypoint method to removeWaypoints and allow removing multiple waypoints at once
• updateWaypoints, then removeWaypoints in here. This might require returning the Onyx.set inside removeWaypoints so we can wait for it, similar to how we wait for the updateWaypoints. We can also optimize it by merging these 2 operations to allow both removing and updating waypoints in 1 Onyx.set operation (something like removeAndUpdateWaypoints), but this will require some refactoring.

What alternative solutions did you explore? (Optional)

NA

[aim-salam]

.

[parasharrajat]

@tienifr's proposal makes sense to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Address is duplicated when dragging one point over an empty point

What is the root cause of that problem?

App/src/libs/actions/Transaction.ts

Line 243 in d4c3e63

return Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {

This is Onyx.merge problem.

What changes do you think we should make in order to solve the problem?

We can use Onyx.set.
But this has many problem. so we need to use Onyx.merge two times.

 comment: {
            waypoints: null
},

and then

comment: {
            waypoints,
},

then we can clear setOptimisticWaypoints(null);

What alternative solutions did you explore? (Optional)

[parasharrajat]

@yh-0218 proposal is in very bad shape.

1. No root cause explanation.
2. You didn't mention what problems...
3. How will this proposal solve the problems?

[yh-0218]

hi, @parasharrajat when drag, waypoints value is correct.
like this {waypoint1: {lab: 1, ...}, waypoint2: {}}
but merged result is {waypoint1: {lab: 1, ...}, waypoint2: {lab: 1, ...}}
To solve this. we will get two step Onyx.merge
This works very well.

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[stephanieelliott]

Hey @tienifr is there a PR for this yet?

[melvin-bot]

@francoisl, @parasharrajat, @stephanieelliott, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tienifr]

There's an edge case that I'm working on.

[parasharrajat]

Waiting on @tienifr's update.

[francoisl]

@tienifr any luck with the new fix?

[tienifr]

I'm opening it today.

[tienifr]

Please review the PR: #37585.

[stephanieelliott]

New PR is on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Duplicated waypoints after dragging #37585

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: $250 ($500*50% regression penalty) @tienifr PAID via Upwork
• Contributor+: $250 ($500*50% regression penalty) @parasharrajat please request via ND

Upwork job is here: https://www.upwork.com/jobs/~019049b6059932909e

[stephanieelliott]

@parasharrajat bump to complete the BZ checklist please!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Add DraggableList component #26307
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26307/files#r1525242780
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Press FAB >> Request money >> Distance
2. Choose one waypoint and leave the other empty
3. Drag one waypoint over another to switch order
4. Verify the empty and the filled waypoints are switched

Do you agree 👍 or 👎 ?

[parasharrajat]

@stephanieelliott Done. Please close it when done. I will request it later.

[parasharrajat]

Payment requested as per #33919 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat