[HOLD for payment 2024-03-20] [LOW] Enable pagination on SelectionList

[cristipaval]

Problem

As part of this issue, we refactored the old gigantic OptionItem component into multiple components focused on specific use cases. The refactoring has taken quite a long time, and in the meantime, pagination was added to the App to make the experience smoother on high-traffic accounts.
Currently, the new component SelectionList doesn't have pagination, and the Search feature in high-traffic accounts doesn't offer the best experience.

Solution

Let's enable pagination on the new SelectionList component.

cc @mountiny

Issue Owner

Current Issue Owner: @cristipaval

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lukemorawski]

@cristipaval reporting for duty 🖖

[cristipaval]

Do we have an update here, @lukemorawski ?

[lukemorawski]

@cristipaval no, sorry, had a more urgent bug fixes. I will be tackling that today

[melvin-bot]

@abekkala, @cristipaval, @lukemorawski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[cristipaval]

I know Callstack devs are quite swamped atm, so most probably, @lukemorawski will have an update on Monday.

[lukemorawski]

@cristipaval yep, I was ooo on Friday. There are also couple of regressions I need address quickly. This ticket is next up in my queue.

[abekkala]

@lukemorawski can you provide an update?

[lukemorawski]

@abekkala started woking on it, but I need to resolve some complicated conflicts on another PR. I should have a PR today in the evening or tomorrow

[melvin-bot]

@abekkala @cristipaval @lukemorawski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[abekkala]

thanks @lukemorawski

[cristipaval]

👀

[abekkala]

@lukemorawski is there any update on this one?

[melvin-bot]

@abekkala @cristipaval @lukemorawski this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[abekkala]

@lukemorawski do you still have some higher priority PRs that is putting this one off for a bit?

[lukemorawski]

Hey. Yes, but I posting one PR today and I'll be waiting for a review, so I should be able to finish this. Fingers crossed 🤞

[lukemorawski]

@abekkala PR is open

[abekkala]

Great @lukemorawski ! Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adding pagination to SelectionList component #37627

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @lukemorawski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
• [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@lukemorawski] Determine if we should create a regression test for this bug.
• [@lukemorawski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR MAR 20

• FIX: @lukemorawski - no payment required
• PR REVIEW: @fedirjh [$500 - if no regression] Offer

@lukemorawski can you complete the checklist above?

[abekkala]

@fedirjh payment sent and contract ended - thank you! 🎉

[abekkala]

no regression test needed