Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-05] [$250] [TS migration] Migrate 'TimePicker' component to TypeScript #36129

Closed
melvin-bot bot opened this issue Feb 8, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Feb 8, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/TimePicker/TimePicker.js 20
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01866e0c4685e41ccd
  • Upwork Job ID: 1757748884199481344
  • Last Price Increase: 2024-02-14
  • Automatic offers:
    • situchan | Reviewer | 0
    • FitseTLT | Contributor | 0
@ghost
Copy link

ghost commented Feb 8, 2024

I want to work on it

@allgandalf
Copy link
Contributor

dibs

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Feb 14, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01866e0c4685e41ccd

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'TimePicker' component to TypeScript [$500] [TS migration] Migrate 'TimePicker' component to TypeScript Feb 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 14, 2024
@FitseTLT
Copy link
Contributor

Would love to work on it

@mountiny mountiny changed the title [$500] [TS migration] Migrate 'TimePicker' component to TypeScript [$250] [TS migration] Migrate 'TimePicker' component to TypeScript Feb 14, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

Upwork job price has been updated to $250

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link
Author

melvin-bot bot commented Feb 14, 2024

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added the Overdue label Feb 22, 2024
@zanyrenney
Copy link
Contributor

what is the latest here @FitseTLT @situchan ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 23, 2024
@situchan
Copy link
Contributor

Looks like @FitseTLT was not available for a while based on other issues he was assigned. @FitseTLT are you back?

@FitseTLT
Copy link
Contributor

Yep. Will create the pr in 2 working days

@blazejkustra
Copy link
Contributor

@FitseTLT Please tag me once it's up!

Copy link
Author

melvin-bot bot commented Mar 21, 2024

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'TimePicker' component to TypeScript [HOLD for payment 2024-04-05] [$250] [TS migration] Migrate 'TimePicker' component to TypeScript Mar 29, 2024
Copy link
Author

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
Copy link
Author

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sorry, something went wrong.

@zanyrenney
Copy link
Contributor

payment summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

7 participants