Wallet - Back button in Wallet loops between Wallet and Add bank account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #39038

Action Performed:

1. Launch New Expensify app
2. Paste the link https://staging.new.expensify.com/settings/wallet/add-bank-account-refactor
   in chat
3. Tap on the link
4. Tap on the back button
5. Tap on the back button again

Expected Result:

After tapping on the back button in Wallet page, app will redirect to settings page

Actual Result:

Back button in Wallet page loops between Wallet and Add bank account page after navigating to https://staging.new.expensify.com/settings/wallet/add-bank-account-refactor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442355_1712584849392.Screen_Recording_20240408_215612_New_Expensify.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[AndrewGable]

Tagging those involved in #39038: @koko57 @barttom @ArekChr @rezkiy37 @shawnborton @Pujan92 @mountiny

Can you see if this regression is related? Thanks

[Pujan92]

Yes, it is related to linked PR. @koko57 I think we should not pass any fallback route for goBack as that pattern I am seeing at other places.

App/src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx

Line 67 in 6ec5811

Navigation.goBack(ROUTES.SETTINGS_WALLET);

As this flow is not open to user yet, we can remove deploy blocker for this.

[AndrewGable]

Just to confirm @Pujan92 - It's under a beta? Or what do you mean by "As this flow is not open to user yet"?

[Pujan92]

Actually, this wallet refactor is still in progress and at the moment the users are navigated to the old flow only(where this issue doesn't persist). New flow navigation will be replaced with the old one once all the steps of refactoring are completed.

[koko57]

@AndrewGable the refactor is still work in progress and all the issues will be resolved in the following PRs.

[mountiny]

I can take over and monitor with @koko57 its part of #36648 and the flow is behind specific route, we will address this in the follow up PRs before we enable the flow for actual users

[mountiny]

Making this monthly as the refactor is ongoing

[mountiny]

The refactor should be done soon, last PR remaining

[mountiny]

the refactor is done. @lanitochka17 could you please retest if this issue is still repro?

[kavimuru]

@mountiny Bug is fixed.

Screen_Recording_20240624_230040_New.Expensify.mp4

[mountiny]

🎉