-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-27] [$500] [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts #42227
Comments
Here is the file you need: emptystate__toddwithphones.svg.zip It should be displayed at 176px wide by 178px tall. We should also have marketing review the copy here as well. |
Job added to Upwork: https://www.upwork.com/jobs/~01632280a607ac1c81 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Add an Illustration and simple directions to the the Submits to screen if there are no contacts What is the root cause of that problem?New feature What changes do you think we should make in order to solve the problem?In here, if we check that the The UI will be a Of course the illustration and directions only show after the list has finished loading, for which there're some indicators like here We can also create a prop We'll likely need a different copy in case of What alternative solutions did you explore? (Optional)There're few cases we need to decide on, they are all straight forward changes once confirmed:
|
Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Also, Do we need to add an Illustration and simple directions to "split expense", "pay someone", and "send invoice"? or we need this only for "submit expense"? |
Yeah, I think all of the create flows that have the search input to search for a contaact would get this kind of empty state. |
@shawnborton Would we keep the same illustration or do we want to add a different illustration for each? @danielrvidal Are you able to handle the copy for each of the flows as they will all be slightly different I assume. Thanks! |
I think the same is fine |
@mountiny Would you mind handling the assignment? So I can start with the PR and will be updating the copy with this once it's available 👍 |
Upwork job price has been updated to $500 |
@tienifr updating the price as this is proving more complex and tedious with the back and forth on the mocks, lets get this over the finish line though |
Love this idea! |
@tienifr @allroundexperts any update here? I just removed the waiting for copy label as I don't think we're waiting for copy anymore. |
@tienifr is trying to address the last pr comments. I hope to merge it this week |
This was just deployed to staging, I just tested it and it's looking good! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Triggered auto assignment to @mallenexpensify ( |
This is ready for payment now; it was a new feature; I am not sure if we need regression tests for this, as it would most likely be caught during random testing. $500 to @tienifr and to @allroundexperts |
Contributor: @tienifr owed $500 via NewDot. QA has monthly regression tests where they check for design-related bugs and edge cases. What about creating the TestRail GH, mentioning that as an option and letting QA make the call? |
Sounds good to me |
Should be all set! Test case GH |
$500 approved for @tienifr |
$500 approved for @allroundexperts |
Problem: Expensify is supposed to make money more efficient and fun. For an organic new user, the first time they send an expense to anyone they do not have any contacts. Thus, they see an empty screen which feels off brand. Especially for such a critical first time experience. It currently looks like this:
Solution: Add a fun illustration (with short and clear directions) to the empty state “Submits to” screen if the user does not have any recent contacts. If there are any recents in the list, we would not show the illustration. It could look like like this:
Current proposed text:
This is being discussed here. @shawnborton can get the final image and @kevinksullivan can help with the https://expensify.slack.com/archives/C03TBKRSB/p1715809342220239?thread_ts=1714766113.560229&cid=C03TBKRSB
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mallenexpensifyThe text was updated successfully, but these errors were encountered: