Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-27] [$500] [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts #42227

Closed
danielrvidal opened this issue May 15, 2024 · 42 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@danielrvidal
Copy link
Contributor

danielrvidal commented May 15, 2024

Problem: Expensify is supposed to make money more efficient and fun. For an organic new user, the first time they send an expense to anyone they do not have any contacts. Thus, they see an empty screen which feels off brand. Especially for such a critical first time experience. It currently looks like this:
image

Solution: Add a fun illustration (with short and clear directions) to the empty state “Submits to” screen if the user does not have any recent contacts. If there are any recents in the list, we would not show the illustration. It could look like like this:
image

Current proposed text:

  • Get paid back
  • Submit your expense to any email or phone number.

This is being discussed here. @shawnborton can get the final image and @kevinksullivan can help with the https://expensify.slack.com/archives/C03TBKRSB/p1715809342220239?thread_ts=1714766113.560229&cid=C03TBKRSB

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01632280a607ac1c81
  • Upwork Job ID: 1791150727815004160
  • Last Price Increase: 2024-07-19
  • Automatic offers:
    • rayane-djouah | Reviewer | 0
    • tienifr | Contributor | 0
Issue OwnerCurrent Issue Owner: @mallenexpensify
@danielrvidal danielrvidal self-assigned this May 15, 2024
@danielrvidal danielrvidal added Weekly KSv2 Planning Changes still in the thought process labels May 15, 2024
@shawnborton
Copy link
Contributor

Here is the file you need: emptystate__toddwithphones.svg.zip

It should be displayed at 176px wide by 178px tall.

We should also have marketing review the copy here as well.

@kevinksullivan kevinksullivan changed the title [Hold] Add an Illustration and simple directions to the the Submits to screen if there are no contacts [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts May 16, 2024
@kevinksullivan kevinksullivan added External Added to denote the issue can be worked on by a contributor and removed Planning Changes still in the thought process labels May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01632280a607ac1c81

@melvin-bot melvin-bot bot changed the title [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts [$250] [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts May 16, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 16, 2024
@tienifr
Copy link
Contributor

tienifr commented May 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add an Illustration and simple directions to the the Submits to screen if there are no contacts

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

In here, if we check that the sections (including all sections like Recents, Contacts, ...) has no user, and there's no search term, show the illustration (the UI is straight forward and is used similarly all around the app)

The UI will be a BlockingView similar to this, we can use Lottie there too if it's an animation (but looks like it's only an SVG icon so should be fine)

Of course the illustration and directions only show after the list has finished loading, for which there're some indicators like here

We can also create a prop ListEmptyComponent in SelectionList to make the feature available anywhere SelectionList is used, too.

We'll likely need a different copy in case of Send money, the above is for Request money only (Send your expense to anyone)

What alternative solutions did you explore? (Optional)

There're few cases we need to decide on, they are all straight forward changes once confirmed:

  • Do we show the illustration if there's search term and there's no search result found?
  • Do we show the illustration when there's no Recents option only (as mentioned in OP), or when there's no option at all (Recents, personal details, ...)

@rayane-djouah
Copy link
Contributor

@tienifr's proposal looks good to me.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented May 18, 2024

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@rayane-djouah
Copy link
Contributor

Do we show the illustration if there's search term and there's no search result found?
Do we show the illustration when there's no Recents option only (as mentioned in OP), or when there's no option at all (Recents, personal details, ...)

Also, Do we need to add an Illustration and simple directions to "split expense", "pay someone", and "send invoice"? or we need this only for "submit expense"?

@shawnborton
Copy link
Contributor

Yeah, I think all of the create flows that have the search input to search for a contaact would get this kind of empty state.

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@mountiny
Copy link
Contributor

@shawnborton Would we keep the same illustration or do we want to add a different illustration for each?

@danielrvidal Are you able to handle the copy for each of the flows as they will all be slightly different I assume. Thanks!

@shawnborton
Copy link
Contributor

I think the same is fine

@tienifr
Copy link
Contributor

tienifr commented May 20, 2024

@mountiny Would you mind handling the assignment?

So I can start with the PR and will be updating the copy with this once it's available 👍

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 20, 2024
@mountiny mountiny added Help Wanted Apply this label when an issue is open to proposals by contributors Waiting for copy User facing verbiage needs polishing labels May 20, 2024
Copy link

melvin-bot bot commented Jul 19, 2024

Upwork job price has been updated to $500

@mountiny
Copy link
Contributor

@tienifr updating the price as this is proving more complex and tedious with the back and forth on the mocks, lets get this over the finish line though

@quinthar
Copy link
Contributor

Love this idea!

@danielrvidal danielrvidal removed the Waiting for copy User facing verbiage needs polishing label Aug 6, 2024
@danielrvidal
Copy link
Contributor Author

@tienifr @allroundexperts any update here? I just removed the waiting for copy label as I don't think we're waiting for copy anymore.

@mountiny
Copy link
Contributor

mountiny commented Aug 8, 2024

@tienifr is trying to address the last pr comments. I hope to merge it this week

@danielrvidal
Copy link
Contributor Author

This was just deployed to staging, I just tested it and it's looking good!

Copy link

melvin-bot bot commented Aug 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Monthly KSv2 labels Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Aug 27, 2024
@mountiny mountiny changed the title [$500] [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts [HOLD for payment 2024-08-27] [$500] [CVP] Add an Illustration and simple directions to the the Submits to screen if there are no contacts Aug 27, 2024
@mountiny
Copy link
Contributor

This is ready for payment now; it was a new feature; I am not sure if we need regression tests for this, as it would most likely be caught during random testing.

$500 to @tienifr and to @allroundexperts

@mallenexpensify
Copy link
Contributor

Contributor: @tienifr owed $500 via NewDot.
Contributor+: @allroundexperts owed $500 via NewDot.

QA has monthly regression tests where they check for design-related bugs and edge cases. What about creating the TestRail GH, mentioning that as an option and letting QA make the call?

@mountiny
Copy link
Contributor

Sounds good to me

@mallenexpensify
Copy link
Contributor

Should be all set! Test case GH

@github-project-automation github-project-automation bot moved this from Release 2.5: SuiteWorld (Sept 9th) to Done in [#whatsnext] #wave-collect Aug 28, 2024
@garrettmknight
Copy link
Contributor

$500 approved for @tienifr

@JmillsExpensify
Copy link

$500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests