[HOLD for payment 2024-07-24] [$250] Submitting Expense from Self DM Results in Duplicate Submissions

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to Self DM and click the plus sign.
2. Select "Track Expense" > "Distance," add start and stop points, and complete the flow.
3. Open the details of the tracked expense and change the date or any field that triggers a notification.
4. When the notification (whisper message) appears, click the "Submit Expense to Someone" button and add an email.
5. Notice that two expenses are submitted, and the UI covers the first expense.

Expected Result:

Only one expense should be submitted, and the UI should not cover the notification

Actual Result:

Submitting an expense from Self DM results in two expenses being submitted, with the first one being covered by the app's UI.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6495276_1717000629458.Screen_Recording_2024-05-29_at_8.21.11_1AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f00d596f8de27d6c
• Upwork Job ID: 1796208453265444864
• Last Price Increase: 2024-06-13
• Automatic offers:
• c3024 | Contributor | 102762962
• dominictb | Contributor | 102962999

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[luacmartins]

This seems to affect only the UI. Gonna remove the web DeployBlocker label.

[stitesExpensify]

Hm Running through these test steps seems to have full on broken my selfDM 😅

Making this external since I can no longer QA it myself...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f00d596f8de27d6c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[stitesExpensify]

@getusha are you able to repro this? I cannot test on staging because my selfDM broke on staging, and it seems to be working on main locally...

[stitesExpensify]

Looks like there is more than one issue here, I'm calling openReport a ton of times too

2024-05-30_11-48-06.mp4

[stitesExpensify]

Regular expense submissions seem to just disappear in the UI too until a refresh

2024-05-30_11-59-43.mp4

[adelekennedy]

@stitesExpensify if we need urgency here should we ask one of our vendors to step in? Callstack/SWM?

[stitesExpensify]

It looks like there are 2 separate problems here.

1. The UI is covering the expense (caused by this pr)
2. We are displaying a single expense twice in the report for some reason (still investigating)

[dominictb]

PR will be ready by tomorrow.

[melvin-bot]

@stitesExpensify, @adelekennedy, @c3024, @dominictb Huh... This is 4 days overdue. Who can take care of this?

[adelekennedy]

@dominictb how is the PR coming along? I see it's in progress, do you need any additional support?

[dominictb]

@adelekennedy nope, all good from my side. The PR should be ready for review by today

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: update logic of filtering created actions from transaction thread report #44946

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Contributor)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

payments made! @c3024 will you complete the checklist?

[adelekennedy]

bump @c3024

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: Polish for one-transaction view  #39472
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: dominictb@2e030d9#r144740854
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because it could not have been caught earlier.
• [@c3024] Determine if we should create a regression test for this bug. Yes

[c3024]

Regression Test Proposal

1. Track a Distance Expense in Self DM
2. Open this tracked expense report and change the date. This triggers a notification changed the date to <new date> previously <old date>
3. Go back to Self DM
4. On the whisper received for the tracked expense in Step 1, click on Submit Expense to Someone > Select a user A and complete the flow
5. Go to the DM with user A > click on this expense preview > go to this expense report
6. Verify that there are no duplicates for either the date change notification or the expense details

[adelekennedy]

https://github.com/Expensify/Expensify/issues/416847