[$250] Next steps are incorrect when there is no approval on a report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717026958410769

Action Performed:

1. Set up workspace with no approvals configured
2. assign expensify card to a member on that workspace
3. Incur a card transaction

Expected Result:

The next steps read should show:

Header: "Finished!"
Subheader: "No further action required!"

Actual Result:

Next steps say this report needs approval.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017287c932cce9e705
• Upwork Job ID: 1797365106853683200
• Last Price Increase: 2024-08-08
• Automatic offers:
• alitoshmatov | Reviewer | 103271393

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017287c932cce9e705

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[MitchExpensify]

What do you think the header should say @kevinksullivan ? Something like this?;

"Waiting for approval."

[melvin-bot]

@MitchExpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@MitchExpensify, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MitchExpensify]

Going to make a call and suggest we remove next steps entirely in this situation so I've updated the OP accordingly.

Waiting on proposals at this point 👀

[MitchExpensify]

What wave collect status do you think this one fits under @trjExpensify ?

[trjExpensify]

Hm, is this part of the pending/scanning implementation? @kevinksullivan didn't we talk about this one using the "finished" terminology for the closed non-reimbursable reports?

[melvin-bot]

@MitchExpensify, @alitoshmatov Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MitchExpensify]

Bumping Slack thread here https://expensify.slack.com/archives/C049HHMV9SM/p1718225472265049?thread_ts=1717026958.410769&cid=C049HHMV9SM

[melvin-bot]

@MitchExpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MitchExpensify]

Updated the expected behavior based on the slack conversation

We need proposals now

[melvin-bot]

@MitchExpensify, @alitoshmatov 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MitchExpensify]

I feel like this might be hot pick worthy, what d'you reckon @trjExpensify ?

[alitoshmatov]

assign expensify card to a member on that workspace

I think we are not going to have any proposals since it requires expensify card

[grgia]

@pasyukevich it looks like this might be specific to ECard transactions, which need to be QAd internally. @kevinksullivan @anmurali could you confirm

[melvin-bot]

@anmurali, @pasyukevich, @grgia, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[grgia]

Awaiting confirmation on expected result here

[melvin-bot]

@anmurali, @pasyukevich, @grgia, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

solution
if the report is a nonreimbursable-only report, then display:

Header: "Finished!"
Subheader: "No further action required!"

[grgia]

Chatted here

There's three cases to fix:

if single expense report and all expenses are pending or scanning show the pending/scanning banner
if single expense report and all expenses are nonreimbursable show the finished banner
if multi expense report and all expenses are nonreimbursable show the finished banner
if multi expense report and some expenses are nonreimbursable show the Waiting for APPROVER to pay expense(s)

[grgia]

I think this case

if single expense report and all expenses are nonreimbursable show the finished banner

Needs to be covered in NextStep.php

[grgia]

https://expensify.slack.com/archives/C03TQ48KC/p1724276550180769
I noticed next steps are missing the titles here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @anmurali, @pasyukevich, @grgia, @alitoshmatov eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[pasyukevich]

@grgia Is there anything that I can help with?

[pasyukevich]

@grgia bump here

[muttmuure]

This seems to be done?

[grgia]

@muttmuure yep this should be done