Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Background in Search page RHP is duplicated and has unnecessary empty space #43247

Closed
JmillsExpensify opened this issue Jun 7, 2024 · 23 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@JmillsExpensify
Copy link

JmillsExpensify commented Jun 7, 2024

cc @Expensify/design for further details. This is what I'm seeing.

CleanShot 2024-06-06 at 22 58 59@2x

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b71ca0f90384f8a8
  • Upwork Job ID: 1800112433179548260
  • Last Price Increase: 2024-06-24
@JmillsExpensify JmillsExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 7, 2024
@JmillsExpensify JmillsExpensify changed the title Background in Search page RHP is duplicated and has unnecessary empty space [Search v1] Background in Search page RHP is duplicated and has unnecessary empty space Jun 7, 2024
@JmillsExpensify
Copy link
Author

Also notice how the background is super-imposed on the receipt verified message as well.

@shawnborton
Copy link
Contributor

@rayane-djouah @yuwenmemon can you please check this one out? This seems like another regression from this PR

@JmillsExpensify JmillsExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
@trjExpensify
Copy link
Contributor

Sending this external so it gets eyes. I don't think @rayane-djouah is around right now.

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Jun 10, 2024
@melvin-bot melvin-bot bot changed the title [Search v1] Background in Search page RHP is duplicated and has unnecessary empty space [$250] [Search v1] Background in Search page RHP is duplicated and has unnecessary empty space Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b71ca0f90384f8a8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

@johncschuster, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@mkhutornyi
Copy link
Contributor

No proposals to review

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2024
@rayane-djouah
Copy link
Contributor

I'm not able to reproduce, @mkhutornyi are you able to?

Copy link

melvin-bot bot commented Jun 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@mkhutornyi
Copy link
Contributor

I'm not able to reproduce, @mkhutornyi are you able to?

Neither am I

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
@rayane-djouah
Copy link
Contributor

@JmillsExpensify - Do you have any reproduction steps?

@luacmartins luacmartins self-assigned this Jun 17, 2024
@luacmartins luacmartins moved this from Release 2: Summer 2024 (Aug) to Polish in [#whatsnext] #wave-collect Jun 17, 2024
@luacmartins
Copy link
Contributor

I'm also unable to reproduce this

Copy link

melvin-bot bot commented Jun 21, 2024

@johncschuster @luacmartins @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

@johncschuster, @luacmartins, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster johncschuster added Needs Reproduction Reproducible steps needed and removed Overdue labels Jun 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2024
@johncschuster
Copy link
Contributor

@JmillsExpensify it seems like no one has been able to reproduce this so far. Are you still experiencing it?

Copy link

melvin-bot bot commented Jun 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@johncschuster
Copy link
Contributor

johncschuster commented Jun 24, 2024

@JmillsExpensify, @shawnborton called out that the behavior Neil has seen here looks similar to what you've described in this issue. Can you take a look at that thread and let me know if the reproduction steps are close to the steps you've taken?

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@johncschuster
Copy link
Contributor

I realize this issue is related to manual requests, but there's gotta be some overlap here 🤔

@luacmartins
Copy link
Contributor

hmm seems like this is not related to Search then. I'll remove this issue from the project since the root cause and issue happen outside the scope of the project too

@luacmartins luacmartins changed the title [$250] [Search v1] Background in Search page RHP is duplicated and has unnecessary empty space [$250] Background in Search page RHP is duplicated and has unnecessary empty space Jun 24, 2024
@johncschuster
Copy link
Contributor

I'm having a hard time finding Manual Requests on the Quarterly release grid. Would this fit into #vip-billpay?

@luacmartins
Copy link
Contributor

@johncschuster we released manual requests ~1y ago, so it won't be on the current release grid. Not sure where this issue would fit since it seems like a generic UI issue (we'll find out once we figure out the root cause)

@luacmartins
Copy link
Contributor

I'm gonna go ahead and close this issue since nobody has been able to reproduce this yet. We can reopen if it's surfaced again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

7 participants