[ON HOLD][Tracking] [External] Attendee Tracking project

[Julesssss]

Important Links

• Design Doc
• Pre-design
• Internal tracking issue

Implementation Issues

Frontend:

• [HOLD for payment 2024-11-05] [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage #47171
• [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for requests #47172
• [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173
• [HOLD for payment 2024-11-05] [Attendee Tracking] Submitter does not appear in attendee search results #48695
• [HOLD for payment 2024-11-05] [HOLD FOR PAYMENT OCTOBER 31st][$250] Merge App Attendee tracking feature branch  #51335

Backend

• https://github.com/Expensify/Expensify/issues/425201
• https://github.com/Expensify/Expensify/issues/419205
• https://github.com/Expensify/Expensify/issues/419206
• https://github.com/Expensify/Expensify/issues/419218
• [Attendee Tracking] Create 'UpdateMoneyRequestAttendees' command to replace 'EditMoneyRequest' #49326

TODO

Finish the project

• https://github.com/Expensify/Expensify/issues/429056
• [Attendee Tracking] Start using the correct nameValuePairs param for Create/Edit #48692
• Update UpdateMoneyRequestAttendees command to return missing onyx data: _transactions, _report, and reportNameValuePairs
• Within createUpdateMoneyRequestAttendees, update the users recent attendees and pass back to client
• App client should update the param used to pass attendees to backend
• App client should switch to the transaction.attendees onyx keys
• Unblock feature in client by reversing this commit

Post-launch polish:

• Clear out uses of the now-unused Auth attendee param
• Prevent violation bug by returning OnyxData like done here for other updates
• Add more tests like testRequestMoneyPersistsAttendees for edit case
• Attendee tracking feature should be a sub-category of 'Rules' #50802
• Once fully migrated, introduce minimum attendee size of 1:
  Request::verifyAttributeSize(request, "attendees", 0, Request::MAX_SIZE_NONCOLUMN);

[Julesssss]

After discussion here, I want to make the document changes much clearer before seeking help from SWM.

[trjExpensify]

I think this is going in #wave-control, right @JmillsExpensify?

[zsgreenwald]

Back from OOO, @Julesssss am I needed anywhere in particular to keep this moving?

[Julesssss]

Hey, it would be helpful to resolve this comment threads, but other than that no, I'll try to hand over the doc to SWM this week.

[Julesssss]

@zsgreenwald actually if you had a chance to check the high-level document again today that would be helpful. I tried to update any section that mentioned the old UI (Avatar instead of Name, etc), but there's a chance I might have missed something.

Then we should be able to open the project up to SWM tomorrow 🤞

[Julesssss]

The design document for this project is now ready for the external teams to make a start on.

myself and @zsgreenwald will be available for any concerns or questions you have while we work on this project. I have added document comments in places that I think are outdated or need changes. Please feel free to resolve these as you work through the document. And to create new comments with any questions you have for us!

Plan should be for the SWM team:

• Read the high-level section for background on the project
• Review, update and improve the detailed section of the document. Paying attention to:
  • Design changes, mainly the switch from Attendee Pills to a Text list of attendees (screenshots below)
  • Codebase changes and refactors since November which make some document details irrelevant/outdated
• Submit the proposed detailed changes for another round of internal feedback
• Start work on the feature, while I handle the back-end changes

---

Previous Design

Updated Design

[filip-solecki]

Hi! I am Filip from SWM and I'd like to work on this issue!

[zfurtak]

Hello, I'm Zuza from SWM and I'd like to work on this issue with Filip :)

[Julesssss]

@dylanexpensify just holding on this briefly -- we need to switch focus to a SmartScan issue that arose from our backend changes to EditRequest

[Julesssss]

This morning I worked through all of the remaining issues/tasks and have organised the issues. We have three remaining issues, two of which are held on an issue I will need to implement. I hope to start on this task this week (after I am able to resolve a HybridApp fire):

Frontend:

• [HOLD for payment 2024-11-05] [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage #47171
• [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for requests #47172
• [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173
• [HOLD for payment 2024-11-05] [Attendee Tracking] Submitter does not appear in attendee search results #48695
• [Attendee Tracking] Start using the correct nameValuePairs param for Create/Edit #48692

Backend

• https://github.com/Expensify/Expensify/issues/425201
• https://github.com/Expensify/Expensify/issues/419205
• https://github.com/Expensify/Expensify/issues/419206
• https://github.com/Expensify/Expensify/issues/419218
• [Attendee Tracking] Create 'UpdateMoneyRequestAttendees' command to replace 'EditMoneyRequest' #49326
• https://github.com/Expensify/Expensify/issues/429056

[Julesssss]

Small update, but I am working on the blocking backend issue as my top priority.

[Julesssss]

Attendee Tracking is currently my top priority, I am making progress with the backend PR that unlocks the other two remaining issues.

I had to switch focus to HybridApp release to resolve a fire, but this is now complete

[Julesssss]

Update:

I have been making slow but steady progress with the new Auth command, while testing the full flow via Web to client. It's likely I will be submitting the Auth command PR soon which passes back attendee data and creates the new action -- but will not update the recent attendees NVP. I'll do that later.

When the Auth PR is merged, Web-E will be next, then I can open up the App issue so that we can adjust the API param names and onyx keys.

[Julesssss]

Internal prioritisation means that this project needs to wind down.

Thankfully the past few weeks has put the project in a good place; the new command is mostly implemented and the onyx attendee data is being passed back to the App clients. I will get the PRs merged, and leave detailed notes on what remains to be done here.

Finish the project

• Within createUpdateMoneyRequestAttendees, update the users recent attendees and pass back to client
• App client should update the param used to pass attendees to backend
• App client should switch to the transaction.attendees onyx keys

Post-launch polish:

• Clear out uses of the now-unused Auth attendee param
• Add more tests like testRequestMoneyPersistsAttendees for edit case
• Attendee tracking feature should be a sub-category of 'Rules' #50802
• Once fully migrated, introduce minimum attendee size of 1:
  Request::verifyAttributeSize(request, "attendees", 0, Request::MAX_SIZE_NONCOLUMN);

[zanyrenney]

When this project is picked back up, mind letting me know? I have a lot of other priorities so I have the help site document ready but I don't want to sink more time into this if it's on pause for now @Julesssss 🙏🏼 Thanks!

[Julesssss]

Yeah, so that I don't forget I assigned myself to your issue and will check in monthly.

[Julesssss]

The task list has been updated. The App feature branch is ready to be merged today and is currently in review.

[Julesssss]

Update regarding the project wind down:

• App feature branch was merged -- this is huge as it contains all our client changes, and I no longer have to keep resolving conflicts with main 🎉
• Web-E branch is blocked, it is not worth making more auth changes in order to finish up a single automated test case. However I think we can easily leave this change until the project is picked back up, so I have officially marked the 'create new command' task as done
• Auth changes were merged already, including automated tests 🎉

[ZhenjaHorbach]

And one more thing 😅
Since the project will be wind down indefinitely
Could I please get paymeny so as not to forget later ? ( I reviewed 3 PR (4 issues))

[Julesssss]

Of course 😄

Please correct me if I forgot, but I think these are the PRs you reviewed?

• Attendee Tracking: Created AttendeeSelectionPage #48008
• Create Attendees item row for editing requests #48870
• Fix bug connected to submitter in attendees #49008

[ZhenjaHorbach]

Of course 😄

Please correct me if I forgot, but I think these are the PRs you reviewed?

• Attendee Tracking: Created AttendeeSelectionPage #48008
• Create Attendees item row for editing requests #48870
• Fix bug connected to submitter in attendees #49008

Yeap
Everything is correct !

[JmillsExpensify]

Still on hold