-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses #45078
Comments
Triggered auto assignment to @sonialiap ( |
Triggered auto assignment to @stitesExpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsb |
ProposalPlease re-state the problem that we are trying to solve in this issue.Grouped expenses row is still slightly grayed out after unselecting the expenses What is the root cause of that problem?App/src/components/Pressable/PressableWithFeedback.tsx Lines 51 to 56 in 6e5a966
On And we don't set What changes do you think we should make in order to solve the problem?set What alternative solutions did you explore? (Optional) |
Not a blocker. Removing from the checklist |
Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new. |
Job added to Upwork: https://www.upwork.com/jobs/~01bcd214466a9b97d7 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
with the PressableWithFeedback is:
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional) |
@nyomanjyotisa I think the RCA isn't correct. Why the list is not greyed out after step 8?
@dominictb My understanding is that the |
It does not trigger onPressIn with the parent container anymore
Yes |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Sorry for the delay 🙏 The proposal from @dominictb looks good to me! 🎀 👀 🎀 C+ reviewed! |
Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Issue not reproducible during KI retests. (First week) |
@sonialiap I think the automation is not working here, the PR already hit production on the 25th of July. Could you give me the payment summary? Thank you! |
No offending PR. It's a pretty rare case and hard to notice.
The regression step should be enough.
|
Payment summary:
|
$250 approved for @mollfpr |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.5-4
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Precondition:
Expected Result:
In Step 7, after unselecting the grouped expenses, the row will not be grayed out.
Actual Result:
In Step 7, after unselecting the grouped expenses, the row is slightly grayed out.
The grayness is gone after clicking on the empty area (Step 9).
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6536029_1720454461384.Screen_Recording_2024-07-08_at_23.34.51.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mollfprThe text was updated successfully, but these errors were encountered: