Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses #45078

Closed
2 of 6 tasks
m-natarajan opened this issue Jul 9, 2024 · 23 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-4
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • User has submitted a few expenses to another user.
  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Go to Shared.
  4. Click on the select all checkbox of the group expenses (not the select all checkbox for all types of expenses, it's the checkbox for the grouped expenses).
  5. Click on the select all checkbox again to unselect.
  6. Move the cursor outside the grouped expenses.
  7. Note the color of the entire row of grouped expenses (it is still slightly grayed out).
  8. Click on any empty area.
  9. Note that the grouped expenses row is now not grayed out at all.

Expected Result:

In Step 7, after unselecting the grouped expenses, the row will not be grayed out.

Actual Result:

In Step 7, after unselecting the grouped expenses, the row is slightly grayed out.
The grayness is gone after clicking on the empty area (Step 9).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536029_1720454461384.Screen_Recording_2024-07-08_at_23.34.51.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bcd214466a9b97d7
  • Upwork Job ID: 1810721978277539440
  • Last Price Increase: 2024-07-16
  • Automatic offers:
    • dominictb | Contributor | 103160053
Issue OwnerCurrent Issue Owner: @mollfpr
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@nyomanjyotisa
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Grouped expenses row is still slightly grayed out after unselecting the expenses

What is the root cause of that problem?

<OpacityView
shouldDim={!!(!rest.disabled && (isPressed || isHovered))}
dimmingValue={isPressed ? pressDimmingValue : hoverDimmingValue}
style={wrapperStyle}
needsOffscreenAlphaCompositing={needsOffscreenAlphaCompositing}
>

On PressableWithFeedback we set the dimmingValue with the pressDimValue if pressed, the default pressDimValue is 0.8, so it set the opacity to 0.8

And we don't set pressDimmingValue here

What changes do you think we should make in order to solve the problem?

set pressDimmingValue={1} here so it wont greyed out after click

What alternative solutions did you explore? (Optional)

@Julesssss
Copy link
Contributor

Not a blocker. Removing from the checklist

@Julesssss Julesssss added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new.

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bcd214466a9b97d7

@melvin-bot melvin-bot bot changed the title Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses [$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses Jul 9, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@dominictb
Copy link
Contributor

dominictb commented Jul 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

  • Grouped expenses row is still slightly grayed out after unselecting the expenses

What is the root cause of that problem?

  • Currently, our row is display as:
<PressableWithFeedback>
    <Checkbox />
</PressableWithFeedback>

with the PressableWithFeedback is:

<OpacityView>
            <GenericPressable
                onPressIn={(event) => {
                    setIsPressed(true);
                    if (rest.onPressIn) {
                        rest.onPressIn(event);
                    }
                }}
                onPressOut={(event) => {
                    setIsPressed(false);
                    if (rest.onPressOut) {
                        rest.onPressOut(event);
                    }
                }}
            >
                {(state) => (typeof children === 'function' ? children(state) : children)}
            </GenericPressable>
        </OpacityView>
  • When we click on the Checkbox to unselect, the isPressed is set to true so that leads to after step 7, the pressDimmingValue: 0.8 is still applied to the row.

What changes do you think we should make in order to solve the problem?

            onMouseDown={(e) => {
                shouldStopPropagation && e.stopPropagation();
                onMouseDown?.(e);
            }}
  • In this case, we create a prop shouldStopPropagation and set it to true.

What alternative solutions did you explore? (Optional)

@dominictb
Copy link
Contributor

Proposal updated

@mollfpr
Copy link
Contributor

mollfpr commented Jul 11, 2024

@nyomanjyotisa I think the RCA isn't correct. Why the list is not greyed out after step 8?


When we click on the Checkbox to unselect, the isPressed is set to true so that leads to after step 7, the pressDimmingValue: 0.8 is still applied to the row.

@dominictb My understanding is that the onPressOut is failing to set the isPressed to false, is that correct? And why stopPropagation is fixing the issue?

@dominictb
Copy link
Contributor

@mollfpr

And why stopPropagation is fixing the issue?

It does not trigger onPressIn with the parent container anymore

My understanding is that the onPressOut is failing to set the isPressed to false, is that correct?

Yes

Copy link

melvin-bot bot commented Jul 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jul 16, 2024
@mollfpr
Copy link
Contributor

mollfpr commented Jul 17, 2024

Sorry for the delay 🙏

The proposal from @dominictb looks good to me!

🎀 👀 🎀 C+ reviewed!

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mollfpr
Copy link
Contributor

mollfpr commented Aug 7, 2024

@sonialiap I think the automation is not working here, the PR already hit production on the 25th of July. Could you give me the payment summary? Thank you!

@mollfpr
Copy link
Contributor

mollfpr commented Aug 7, 2024

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. It's a pretty rare case and hard to notice.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

  1. Go to NewDot
  2. Go to Search.
  3. Go to Shared.
  4. Click on the select all checkbox of the group expenses (not the select all checkbox for all types of expenses, it's the checkbox for the grouped expenses).
  5. Click on the select all checkbox again to unselect.
  6. Move the cursor outside the grouped expenses.
  7. Verify that the row will not be grayed out.
  8. 👍 or 👎

@sonialiap
Copy link
Contributor

Payment summary:

@JmillsExpensify
Copy link

$250 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants