[HOLD for payment 2024-08-02] [$125] Dupe detect - Receipt field is not disabled and green thumbnail is shown after adding receipt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547677_1721436317991.20240720_084308.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019db4c5df08390374
• Upwork Job ID: 1815200683754172578
• Last Price Increase: 2024-07-22
• Automatic offers:
• Krishna2323 | Contributor | 103212255

Issue Owner

Current Issue Owner: @jayeshmangwani

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detect - Receipt field is not disabled and green thumbnail is shown after adding receipt

What is the root cause of that problem?

We aren't disabling the empty receipt view when readonly prop is true in MoneyRequestView.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 467 to 481 in fa738c6

	<ReceiptEmptyState
	hasError={hasErrors}
	disabled={!canEditReceipt}
	onPress={() =>
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
	CONST.IOU.ACTION.EDIT,
	iouType,
	transaction?.transactionID ?? '-1',
	report?.reportID ?? '-1',
	Navigation.getActiveRouteWithoutParams(),
	),
	)
	}
	/>

What changes do you think we should make in order to solve the problem?

We should add || readonly to disabled prop of ReceiptEmptyState.

disabled={!canEditReceipt || readonly}

What alternative solutions did you explore? (Optional)

We might also want to disable the receipt view when receipt is present, for that we can update enablePreviewModal prop to enablePreviewModal={!readonly}

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 452 to 460 in fa738c6

	<ReportActionItemImage
	thumbnail={receiptURIs?.thumbnail}
	fileExtension={receiptURIs?.fileExtension}
	isThumbnail={receiptURIs?.isThumbnail}
	image={receiptURIs?.image}
	isLocalFile={receiptURIs?.isLocalFile}
	filename={receiptURIs?.filename}
	transaction={transaction}
	enablePreviewModal

[mountiny]

Dupe detection is behind beta so we can remove the blocker

cc @kubabutkiewicz @pecanoro @parasharrajat

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019db4c5df08390374

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[melvin-bot]

Upwork job price has been updated to $125

[jayeshmangwani]

@Krishna2323 Your solution does not work for me. Can you please test it and check if it works for you?

I think adding disabled={!canEditReceipt || readonly} will not work here. It will disable the navigation, and then we cannot select the receipt.

[Krishna2323]

I think adding disabled={!canEditReceipt || readonly} will not work here. It will disable the navigation, and then we cannot select the receipt.

@jayeshmangwani, I think this is the expected behaviour, user should be not allowed to add receipt on dupe review confirmation page just like any other field.

Monosnap.screencast.2024-07-22.13-07-15.mp4

[jayeshmangwani]

user should be not allowed to add receipt on dupe review confirmation page just like any other field.

I missed that the other fields are also disabled. I was only thinking about the empty state of the receipt.

[jayeshmangwani]

@Krishna2323 's Proposal to disable the ReceiptEmptyState when readonly is true looks good to me

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @robertjchen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[robertjchen]

ok- let's move forward with @Krishna2323 proposal, thanks!

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Receipt field is not disabled on dupe detect confirmation page. #45877

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[jayeshmangwani]

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Feat/dupe detection confirmation #42571
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Feat/dupe detection confirmation #42571 (comment)
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@jayeshmangwani] Determine if we should create a regression test for this bug. This feature is behind the beta. I don't think it needs regression testing at the moment.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @miljakljajic you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[miljakljajic]

@jayeshmangwani is owed 125 USD for their work on this issue

@Krishna2323 was paid in Upwork

[jayeshmangwani]

Requested as per #45814 (comment)

[JmillsExpensify]

$125 approved for @jayeshmangwani