[HOLD for payment 2024-08-01] [$125] Workspace - Avatar for a deleted workspace is empty when viewed full screen

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Click on the chat header.
5. Click workspace avatar.
6. Note that it opens avatar in full screen.
7. Delete the workspace.
8. Go to workspace chat.
9. Click on the chat header.
10. Click workspace avatar.

Expected Result:

Avatar for a deleted workspace will still display when viewed full screen.

Actual Result:

Avatar for a deleted workspace is empty when viewed full screen.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6547912_1721465119586.20240720_164112.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e8484784facf391c
• Upwork Job ID: 1814778937726286060
• Last Price Increase: 2024-07-20

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@mollfpr @b4s36t4 This one seems related to your PR #44702 can you please confirm if revert fixes it?

[mountiny]

Not fixed with the revert

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e8484784facf391c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Exporting, but also I would say we can demote if we cannot find a fix soon before the deploy is ready as its minor ux issue

[Ahmed-Abdella]

Not completely sure, but I think it comes from this PR #41586

[mountiny]

@m-natarajan I think you can add it to this one

[mountiny]

@s77rt @nexarvo are you able to have a look, if not, there is a revert PR ready if we need to unblock the deploy

[abdulrahuman5196]

@mountiny Seems there is a revert PR, should I need to do anything here?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Add support for viewing full screen Group Chat custom avatars" #45863

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

@VictoriaExpensify I'm heading OOO starting this afternoon, so reassigning for payment! TY!

[mountiny]

This can be close as there was no c+ review on the revert