[Awaiting Payment 4th Sept] NetSuite - "Custom segment" text is displayed for an added custom record

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the app
2. Log in with a new expensifail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to NetSuite and upgrade the workspace to Control when asked
7. Wait for the sync to finish
8. Navigate to Accounting - Import - Custom Segments/records
9. Click on the "Add custom segment/record" button
10. Add a Custom record with any random data

Expected Result:

The text should be "Custom record"

Actual Result:

"Custom segment" text is displayed for an added custom record.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6557352_1722346651568.bandicam_2024-07-30_15-36-14-133.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[rushatgabhane]

cc @shubham1206agra ?

[trjExpensify]

Can we get this assigned to who implemented it to fix it? CC: @zsgreenwald

[shubham1206agra]

I don't think we have control over this, as BE doesn't differentiate between Custom segments and Custom records.

[trjExpensify]

Cool, so the push row should take the same approach we have with the page title and description.

E.g

Custom segment / record
1234                                >

CC: @jamesdeanexpensify this is what it looks like now:

[jamesdeanexpensify]

sounds good! maybe without the extra spaces in between, though? So Custom segment/record

[trjExpensify]

Cool, @shubham1206agra want to take it?

[trjExpensify]

bump! :)

[melvin-bot]

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Any movement?

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

PR is on staging.

[trjExpensify]

Automation failed, due for payment tomorrow. Updated the labels/titles, and added @Ollyws as the C+ reviewer.

[trjExpensify]

Payment summary as follows:

• $125 to @shubham1206agra for the fix
• $125 to @Ollyws for the C+ review

(dropped the price for some copy changes)

[trjExpensify]

@Ollyws go ahead and request on ND, @shubham1206agra can you confirm if you've been paid for the NS implementation elsewhere?

[shubham1206agra]

I have been paid for the entire NS implementation somewhere else.

But this needs to be paid separately.

[trjExpensify]

Care to expand a touch on why? Fixing the copy of a label during implementation of the project I'd have thought is just par for the course. 😕

[shubham1206agra]

Since I am not 100% sure, I am gonna ask @yuwenmemon to confirm what we should do here.

[yuwenmemon]

@shubham1206agra Yeah, I'd consider this a regression from your implementation as opposed to, say, your work in #47493, which would be adding additional improvements to the NetSuite integration project. Plenty of NetSuite and integrations work still to be done though and you're one of the best suited C+ for it 🙂

[Ollyws]

Requested in ND.

[trjExpensify]

Great, I'm going to close this then. Thanks!

[garrettmknight]

$125 approved for @Ollyws