Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-13] [Fullstory] Unmasking session data in Fullstory #46579

Closed
anmurali opened this issue Jul 31, 2024 · 17 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@anmurali
Copy link

Problem: We have the FS implementation done 95% of the way. There is still a bit of clean up to do and we're working on it but the integration is ready for us to use. There are a multitude of ways to use this data but a pretty core one is watching session data to understand pockets of user confusion. But right now we're sending the data completely masked. When we observe the session, it is a hard to follow what the user is even clicking on. We tried selectively unmasking the data but this is a piecemeal effort across many many pages and is effectively going to delay us getting value out of this tool in short order

Solution: Lets unmask the data by default and get started. Our user segments exclude emails with domain expensify.com so by design we won't be tracking or watching those sessions. And all of us have access to supportal anyway, where all the data is available.

Lean Convert will be working on this build
Expensify Order Form Experimentation 18-07-24.docx (2) (1).pdf

@luacmartins luacmartins self-assigned this Jul 31, 2024
@luacmartins luacmartins added the Daily KSv2 label Aug 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
@anmurali anmurali changed the title Unmasking session data in Fullstory [Fullstory] Unmasking session data in Fullstory Aug 5, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Aug 5, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 6, 2024
@melvin-bot melvin-bot bot changed the title [Fullstory] Unmasking session data in Fullstory [HOLD for payment 2024-08-13] [Fullstory] Unmasking session data in Fullstory Aug 6, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-13. 🎊

@anmurali
Copy link
Author

anmurali commented Aug 6, 2024

Loaded sessions from the last hour to check in FS and everything is mostly still masked..
So I think we need to dig into this more to figure out why its not working as expected @LCOleksii. @rushatgabhane maybe you can take over the QA from @luacmartins here in the interest of optimizing internal resources for other projects?

@luacmartins
Copy link
Contributor

It'd be great if @rushatgabhane can take investigation/QA over.

@rushatgabhane
Copy link
Member

sounds good

@anmurali
Copy link
Author

FS is still looking into this. No updates yet.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 12, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

Issue is ready for payment but no BZ is assigned. @sakluger you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

Payment Summary

Upwork Job

BugZero Checklist (@sakluger)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@sakluger
Copy link
Contributor

@luacmartins can you please confirm who needs to be paid for this issue? It's hard to tell based on the issue assignees vs the PR author and reviewer.

@luacmartins
Copy link
Contributor

That would be @LCOleksii for the 1st PR linked to the issue. I'm not sure if they have some pre-agreement for this project though. @anmurali can you confirm?

@sakluger
Copy link
Contributor

@LCOleksii how are you getting paid for this PR? Through Upwork, NewDot, or is it already handled elsewhere?

@melvin-bot melvin-bot bot added the Overdue label Aug 16, 2024
@sakluger
Copy link
Contributor

I asked for guidance around payments on Slack: https://expensify.slack.com/archives/C02NK2DQWUX/p1723826353151379

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 16, 2024
@sakluger
Copy link
Contributor

@luacmartins do you @LCOleksii's email or name on Slack? @anmurali is OOO for the rest of the week and @LCOleksii has not responded on this GH issue, so I'm not sure how else to find out what needs to happen for payments.

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@sakluger
Copy link
Contributor

Oh - I see an order form with LeanConvert in the original comment/description for this GH issue, which confirms that we're paying them separately.

I do see that @rushatgabhane reviewed the PR, so I think we do actually have to pay Rushat. @luacmartins can you please confirm if Rushat is due payment for reviewing?

@luacmartins
Copy link
Contributor

I think so, but maybe @rushatgabhane is also being paid a fixed price for being a dedicated C+ to this project? @rushatgabhane can you please confirm?

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2024
@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 21, 2024

Hey @luacmartins the PR did not require any time to review because we just added a new class name. So no pay required here

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@sakluger
Copy link
Contributor

Got it, thanks for clarifying! I assume that @LCOleksii was paid in a separate agreement, so I will close for now. Feel free to reopen if additional payment is required.

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants