Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [OldDot Rules Migration] Expense report rules #47014

Closed
marcaaron opened this issue Aug 7, 2024 · 19 comments
Closed

[$250] [OldDot Rules Migration] Expense report rules #47014

marcaaron opened this issue Aug 7, 2024 · 19 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Aug 7, 2024

Part of the OldDot Rules Migration project

Main issue: https://github.com/Expensify/Expensify/issues/413886

Feature Description

2024-08-07_13-57-29
2024-08-07_14-35-32
2024-08-07_14-39-03
2024-08-07_14-36-27
2024-08-07_14-36-21
2024-08-07_14-36-13
2024-08-07_14-35-47

High Level Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.m0kga74f5qa8

Detailed Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.dnpn3lehspjl

Manual Test Steps

TBD

Automated Tests

TBD

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021844160179253102195
  • Upwork Job ID: 1844160179253102195
  • Last Price Increase: 2024-10-09
Issue OwnerCurrent Issue Owner: @
@BrtqKr
Copy link
Contributor

BrtqKr commented Aug 9, 2024

Hey, I'm from SWM, I'd like to take over this issue, would you please assign me?

@marcaaron
Copy link
Contributor Author

Assigned!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 12, 2024
@marcaaron marcaaron added Daily KSv2 Engineering NewFeature Something to build that is a new item. and removed Monthly KSv2 labels Aug 14, 2024
Copy link

melvin-bot bot commented Aug 14, 2024

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 14, 2024
@marcaaron marcaaron added Daily KSv2 and removed Weekly KSv2 labels Aug 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

@marcaaron, @BrtqKr Eep! 4 days overdue now. Issues have feelings too...

@garrettmknight
Copy link
Contributor

@BrtqKr when do you expect to make progress on this one?

@BrtqKr
Copy link
Contributor

BrtqKr commented Aug 20, 2024

@garrettmknight, the functionality in the PR is ready, we're waiting to merge the PR with enabling expense rules for the workspace before both sections to limit the diff. After that I'll record the videos and pass it further

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Aug 20, 2024
@marcaaron
Copy link
Contributor Author

What's your email?

@DylanDylann
Copy link
Contributor

Ah sorry. My email: dylandylan9112@gmail.com

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 9, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 9, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Oct 2, 2024

This issue has not been updated in over 15 days. @marcaaron, @BrtqKr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@DylanDylann
Copy link
Contributor

@marcaaron This is ready for payment. Could you please assign a BZ to handle payment? 🙏

@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

Triggered auto assignment to @VictoriaExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Oct 9, 2024
@marcaaron
Copy link
Contributor Author

@VictoriaExpensify can you help pay @DylanDylann and then close this out after? It's done and just waiting for payment.

@VictoriaExpensify VictoriaExpensify added Internal Requires API changes or must be handled by Expensify staff External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 9, 2024
@melvin-bot melvin-bot bot changed the title [OldDot Rules Migration] Expense report rules [$250] [OldDot Rules Migration] Expense report rules Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021844160179253102195

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 9, 2024
@VictoriaExpensify
Copy link
Contributor

Hey @DylanDylann - I've sent you a job offer, can you please accept so I can pay you? https://www.upwork.com/nx/wm/offer/104347866

@DylanDylann
Copy link
Contributor

@VictoriaExpensify Sure I did accept

@VictoriaExpensify
Copy link
Contributor

Contributor: @BrtqKr - No payment required, Contractor
Contributor+: @DylanDylann paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Archived in project
Development

No branches or pull requests

6 participants