Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hasStrictAdvancedApproval #47517

Closed
youssef-lr opened this issue Aug 15, 2024 · 38 comments
Closed

Implement hasStrictAdvancedApproval #47517

youssef-lr opened this issue Aug 15, 2024 · 38 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task

Comments

@youssef-lr
Copy link
Contributor

youssef-lr commented Aug 15, 2024

Implement hasStrictAdvancedApproval similar to what we have in Auth and use it when checking if submitted expenses can be edited in Control.

#47398 (comment)

@youssef-lr youssef-lr self-assigned this Aug 15, 2024
@youssef-lr youssef-lr added Engineering Internal Requires API changes or must be handled by Expensify staff Task labels Aug 15, 2024
@youssef-lr youssef-lr changed the title Add strictworkFlow check when editing submitted reports in Control Implement hasStrictAdvancedApproval Aug 15, 2024
@youssef-lr youssef-lr added the Daily KSv2 label Aug 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@youssef-lr
Copy link
Contributor Author

On it this week

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 20, 2024
Copy link

melvin-bot bot commented Aug 26, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor Author

Will try to to get to this this week

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2024
Copy link

melvin-bot bot commented Sep 2, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Sep 4, 2024

@youssef-lr Still overdue 6 days?! Let's take care of this!

@youssef-lr
Copy link
Contributor Author

No update yet, will get to this soon this week or Monday

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 5, 2024
@youssef-lr
Copy link
Contributor Author

Will get to this when I'm done with the Auth PR for adding expenses to submitted reports in Control

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 10, 2024
Copy link

melvin-bot bot commented Sep 13, 2024

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Sep 17, 2024

@youssef-lr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@youssef-lr
Copy link
Contributor Author

On it this week

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 18, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Oct 29, 2024

@youssef-lr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@youssef-lr
Copy link
Contributor Author

No update yet

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 30, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor Author

No update yet

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 5, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Nov 13, 2024

@youssef-lr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@youssef-lr
Copy link
Contributor Author

I'm on this next week

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 13, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor Author

I have some spare cycles now and can tacke this this week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 20, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@youssef-lr Huh... This is 4 days overdue. Who can take care of this?

@youssef-lr
Copy link
Contributor Author

I got caught up with a customer issue and couldn't get to this yet.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 26, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@youssef-lr Huh... This is 4 days overdue. Who can take care of this?

@youssef-lr
Copy link
Contributor Author

No update, I couldn't get to this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 4, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor Author

We don't need this anymore as we're changing the logic of how we check for forwarded reports and it won't matter whether the policy has strict workflow or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

1 participant