Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] NetSuite - Inconclusive use of spaces before and after a backslash #47550

Closed
5 of 6 tasks
izarutskaya opened this issue Aug 16, 2024 · 18 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.21-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #47091
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open the app
  2. Log in with a new Gmail account
  3. Click on FAB - New workspace
  4. Enable "Accounting" in the "More features" page.
  5. Navigate to "Accounting"
  6. Connect to NetSuite and upgrade the workspace to Control when asked
  7. Wait for the sync to finish
  8. Navigate to Accounting - Import

Expected Result:

All of the options should follow a similar syntax: "text/text" or "text / text".

Actual Result:

Inconclusive use of spaces before and after a backslash. One option is "Custom segments/records", the other is "Customers / projects".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6573587_1723784432596.bandicam_2024-08-16_06-46-56-545.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad3e945fffc220c0
  • Upwork Job ID: 1825680410861600909
  • Last Price Increase: 2024-08-19
  • Automatic offers:
    • shubham1206agra | Contributor | 103678598
Issue OwnerCurrent Issue Owner: @Ollyws
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya
Copy link
Author

We think this issue might be related to the #wave-control

@daledah
Copy link
Contributor

daledah commented Aug 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconclusive use of spaces before and after a backslash. One option is "Custom segments/records", the other is "Customers / projects".

What is the root cause of that problem?

Copy errors.

What changes do you think we should make in order to solve the problem?

Modify these copy following same standard. Seems like all the segment/record copies have that same inconsistency.

title: 'Custom segments/records',

addText: 'Add custom segment/record',

helpText: ' on configuring custom segments/records.',

Copy link

melvin-bot bot commented Aug 19, 2024

@VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@VictoriaExpensify
Copy link
Contributor

I agree that this should be consistent. A low priority but we should fix it

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@VictoriaExpensify VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ad3e945fffc220c0

@melvin-bot melvin-bot bot changed the title NetSuite - Inconclusive use of spaces before and after a backslash [$250] NetSuite - Inconclusive use of spaces before and after a backslash Aug 19, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@Ollyws
Copy link
Contributor

Ollyws commented Aug 20, 2024

I need Netsuite credentials before testing this one so I have requested in slack.

@shubham1206agra
Copy link
Contributor

As discussed internally, I will pick this up. And @Ollyws will be the reviewer.

Copy link

melvin-bot bot commented Aug 23, 2024

@Ollyws, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Aug 23, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 26, 2024
Copy link

melvin-bot bot commented Aug 26, 2024

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

@Ollyws, @VictoriaExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

@Ollyws @VictoriaExpensify @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Ollyws
Copy link
Contributor

Ollyws commented Aug 30, 2024

Deployed to production 4 days ago.

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
@Ollyws
Copy link
Contributor

Ollyws commented Sep 3, 2024

@VictoriaExpensify This one's due for payment today, thanks.

@Ollyws
Copy link
Contributor

Ollyws commented Sep 5, 2024

this one is getting sorted in #46540 so I think we can close this.

Copy link

melvin-bot bot commented Sep 10, 2024

@Ollyws, @VictoriaExpensify, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 10, 2024
@VictoriaExpensify
Copy link
Contributor

Closing as the issue was fixed elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Archived in project
Development

No branches or pull requests

5 participants