Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustration gets hidden behind the search field #47553

Closed
2 of 6 tasks
IuliiaHerets opened this issue Aug 16, 2024 · 10 comments
Closed
2 of 6 tasks

Illustration gets hidden behind the search field #47553

IuliiaHerets opened this issue Aug 16, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.21-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #42413
Email or phone of affected tester (no customers): nathanmulugetatesting+hakmw@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com and sign up with a new Gmail account
  2. Click on FAB > Submit expense
  3. Enter an amount and click next

Expected Result:

The illustration becomes fully visible while the keyboard is up

Actual Result:

Some part of the illustration gets hidden behind the search field if the keyboard is up

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6573673_1723793621345.Screen_Recording_20240816_102521_Chrome.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 16, 2024
@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-vsb

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets IuliiaHerets changed the title mWeb - Illustration gets hidden behind the search field Illustration gets hidden behind the search field Aug 16, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 16, 2024
@Beamanator
Copy link
Contributor

Supposedly this is also getting fixed in #47555

@nkuoch
Copy link
Contributor

nkuoch commented Aug 18, 2024

@IuliiaHerets Can you check if it's been fixed by #47555?

@IuliiaHerets
Copy link
Author

@nkuoch The issue is no longer reproduced on mWeb and Android app

Screen_Recording_20240819_072619_New.Expensify.mp4
Screen_Recording_20240819_072424_Chrome.mp4

@joekaufmanexpensify
Copy link
Contributor

@nkuoch that means we're good to close this?

@Beamanator
Copy link
Contributor

Nice, looks like it!

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Aug 19, 2024
@joekaufmanexpensify
Copy link
Contributor

Sweet. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants