-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Advanced Approval Workflows] Update the hint text to be simpler #47699
Comments
Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue! |
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. |
Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new. |
Hi @blazejkustra! It's all yours! |
@JmillsExpensify @tgolen Please check out this thread, and let me know what do you think. Should we make the message more generic or you have another idea in mind, thanks! |
I think the copy you proposed looks good to me.
…On Tue, Aug 20, 2024 at 10:05 AM Błażej Kustra ***@***.***> wrote:
@JmillsExpensify <https://github.com/JmillsExpensify> @tgolen
<https://github.com/tgolen> Please check out this
<#46798 (comment)>
thread, and let me know what do you think. Should we make the message more
generic or you have another idea in mind, thanks!
—
Reply to this email directly, view it on GitHub
<#47699 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAB22GMYUSI2C2AQFNW3ZSNEJRAVCNFSM6AAAAABMZU4XH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYHE2DQMBVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, that looks good to me as well. cc @jamesdeanexpensify this is the copy if you have any alt suggestions.
|
It looks like we show the email already in the
Just curious though, how will all other workflows be updated? Like, what will change in the others? Maybe we could make it even clearer. |
We previously had a more specific example but we ended up discovering that it's not general enough to work in the breadth of scenarios required. |
Understood. Let me know if you think my suggestion works, or we could go even shorter:
|
That could work! Ultimately I'm not too passionate as nailing this message is hard and will depend on customer feedback. |
All yours @DylanDylann |
Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
I am pretty sure this has been deployed to prod, @DylanDylann are you due payment here? |
bump @DylanDylann |
Ahh yes,waiting for payment |
Triggered auto assignment to @puneetlath ( |
@puneetlath I guess this is deployed to prod for a while now, so we just need to issue payment for @DylanDylann |
Offer is here: https://www.upwork.com/nx/wm/offer/104055843 @DylanDylann ping me on this issue when you've accepted. |
@puneetlath Done it thanks |
Ok paid. Thanks everyone! |
Coming from this project, we have this follow-up polish issue we need to complete where we update the hint text to be simpler. More details here.
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: