Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Approval Workflows] Update the hint text to be simpler #47699

Closed
dylanexpensify opened this issue Aug 20, 2024 · 23 comments
Closed

[Advanced Approval Workflows] Update the hint text to be simpler #47699

dylanexpensify opened this issue Aug 20, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task

Comments

@dylanexpensify
Copy link
Contributor

dylanexpensify commented Aug 20, 2024

Coming from this project, we have this follow-up polish issue we need to complete where we update the hint text to be simpler. More details here.

Issue OwnerCurrent Issue Owner: @
@dylanexpensify
Copy link
Contributor Author

cc @blazejkustra

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@dylanexpensify dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 20, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 20, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@dylanexpensify
Copy link
Contributor Author

Hi @blazejkustra! It's all yours!

@blazejkustra
Copy link
Contributor

@JmillsExpensify @tgolen Please check out this thread, and let me know what do you think. Should we make the message more generic or you have another idea in mind, thanks!

@tgolen
Copy link
Contributor

tgolen commented Aug 20, 2024 via email

@JmillsExpensify
Copy link

Yes, that looks good to me as well. cc @jamesdeanexpensify this is the copy if you have any alt suggestions.

dylandylan9112+9366@gmail.com is already used in a separate workflow. If you change this approval relationship, all other workflows will be updated.

@jamesdeanexpensify
Copy link
Contributor

It looks like we show the email already in the Second approver field, so we might not even need to repeat it. So maybe we could tweak it and do:

This member already belongs to another approval workflow. If you change this approval relationship, all other workflows will be updated.

Just curious though, how will all other workflows be updated? Like, what will change in the others? Maybe we could make it even clearer.

@JmillsExpensify
Copy link

We previously had a more specific example but we ended up discovering that it's not general enough to work in the breadth of scenarios required.

@jamesdeanexpensify
Copy link
Contributor

Understood. Let me know if you think my suggestion works, or we could go even shorter:

This member already belongs to at least one other approval workflow. Any updates here will reflect there, too.

@JmillsExpensify
Copy link

That could work! Ultimately I'm not too passionate as nailing this message is hard and will depend on customer feedback.

@blazejkustra
Copy link
Contributor

All yours @DylanDylann

#47860

@blazejkustra
Copy link
Contributor

Copy link

melvin-bot bot commented Aug 26, 2024

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@rlinoz rlinoz removed the Reviewing Has a PR in review label Sep 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Sep 13, 2024

I am pretty sure this has been deployed to prod, @DylanDylann are you due payment here?

@melvin-bot melvin-bot bot removed the Overdue label Sep 13, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Sep 20, 2024

bump @DylanDylann

@DylanDylann
Copy link
Contributor

Ahh yes,waiting for payment

@rlinoz rlinoz added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 20, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 20, 2024
@rlinoz rlinoz added the Awaiting Payment Auto-added when associated PR is deployed to production label Sep 20, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Sep 20, 2024

@puneetlath I guess this is deployed to prod for a while now, so we just need to issue payment for @DylanDylann

@puneetlath
Copy link
Contributor

Offer is here: https://www.upwork.com/nx/wm/offer/104055843

@DylanDylann ping me on this issue when you've accepted.

@DylanDylann
Copy link
Contributor

@puneetlath Done it thanks

@puneetlath
Copy link
Contributor

Ok paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task
Projects
Archived in project
Development

No branches or pull requests

8 participants