[$250] iOS - Distance - Center button icon is not centered

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Submit expense
3. Go to Distance

Expected Result:

Center button icon will be centered

Actual Result:

Center button icon is not centered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018cfba37db6e03a8f
• Upwork Job ID: 1828533917426975142
• Last Price Increase: 2024-08-27
• Automatic offers:
• Nodebrute | Contributor | 103709522

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018cfba37db6e03a8f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Center button icon is not centered

What is the root cause of that problem?

We are adding extra margin here
https://github.com/Expensify/App/blob/e5b6cef118381ce7eb273a722f45cca92e7010fd/src/components/MapView/MapView.tsx#L285C28-L285C52

What changes do you think we should make in order to solve the problem?

We should remove this extra margin
https://github.com/Expensify/App/blob/e5b6cef118381ce7eb273a722f45cca92e7010fd/src/components/MapView/MapView.tsx#L285C28-L285C52
Result:

What alternative solutions did you explore? (Optional)

[bondydaa]

this is most likely caused b/c we updated RN versions which also bumped the mapbox version so not exactly sure if we have some custom styles being applied that just need modifying or what.

context pr #45289

[Nodebrute]

@bondydaa bump on this proposal: #48120 (comment)

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

The Pr is ready for review #48125

[Nodebrute]

This was deployed to production in v9.0.26-6.
Payment is due 2024-09-06.

[bondydaa]

oh just realizing there is no Bug assignment here so adding that to get someone on it to pay out.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bondydaa]

@CortneyOfstad believe payment is due tomorrow, i don't think the automation ran b/c bug was missing

[CortneyOfstad]

Payment Summary

@Nodebrute — paid $250 via Upwork
@abdulrahuman5196 — to be paid $250 via NewDot

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Caused indirectly by RN upgrades

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Launch New Expensify app
2. Go to FAB > Submit expense
3. Go to Distance
4. Verify map center button is centered

@CortneyOfstad

[JmillsExpensify]

$250 approved for @abdulrahuman5196

[JmillsExpensify]

Re-opening for regression test.

[melvin-bot]

@bondydaa @CortneyOfstad @abdulrahuman5196 @Nodebrute this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@bondydaa, @CortneyOfstad, @abdulrahuman5196, @Nodebrute Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

Sorry, was OoO yesterday — @abdulrahuman5196 where are we at with the regression correction?

[abdulrahuman5196]

@CortneyOfstad Here is the regression test - #48120 (comment)

[melvin-bot]

@bondydaa, @CortneyOfstad, @abdulrahuman5196, @Nodebrute Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

Oh, I am sorry about that! I misread and thought the fix went into regression, not that a regression test was needed 🤦‍♀️

Getting that sorted now!

[CortneyOfstad]

Regression Test

https://github.com/Expensify/Expensify/issues/433432