[$250] Invoice - No option 'Pay via Expensify' for receiver #48486

lanitochka17 · 2024-09-03T15:06:59Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3073288
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: workspace with a member added

Click FAB > Send invoice
Enter amount
Choose receiver
Choose workspace
Send invoice
As a receiver, open invoice room
Click on invoice preview
Click on Pay button in a header

Expected Result:

There are options 'Pay elsewhere' and 'Pay via Expensify' in a button dropdown

Actual Result:

There are options 'Pay as business' and 'Pay as an individual' in a button dropdown. No 'Pay via Expensify'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6591768_1725371898335.pay_invoice.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015c21e7f83c78f5bb
Upwork Job ID: 1831071012017220335
Last Price Increase: 2024-09-03

Issue Owner

Current Issue Owner: @jayeshmangwani

melvin-bot · 2024-09-03T15:07:08Z

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions · 2024-09-03T17:09:13Z

@user Your proposal will be dismissed because you did not follow the proposal template.

MuaazArshad · 2024-09-03T17:16:50Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

No option 'Pay via Expensify' for receiver

What is the root cause of that problem?

We are not pushing pay with expensify option in button options

App/src/components/SettlementButton.tsx

Lines 215 to 260 in 0139133

    
           if (canUseWallet || (isExpenseReport && shouldShowPaywithExpensifyOption)) { 
        
               buttonOptions.push(paymentMethods[CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT]); 
        
           } 
        
           if (shouldShowPayElsewhereOption) { 
        
               buttonOptions.push(paymentMethods[CONST.IOU.PAYMENT_TYPE.ELSEWHERE]); 
        
           } 
        
           if (isInvoiceReport) { 
        
               if (ReportUtils.isIndividualInvoiceRoom(chatReport)) { 
        
                   buttonOptions.push({ 
        
                       text: translate('iou.settlePersonal', {formattedAmount}), 
        
                       icon: Expensicons.User, 
        
                       value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                       backButtonText: translate('iou.individual'), 
        
                       subMenuItems: [ 
        
                           { 
        
                               text: translate('iou.payElsewhere', {formattedAmount: ''}), 
        
                               icon: Expensicons.Cash, 
        
                               value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                               onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE), 
        
                           }, 
        
                       ], 
        
                   }); 
        
               } 
        
               if (PolicyUtils.isPolicyAdmin(primaryPolicy) && PolicyUtils.isPaidGroupPolicy(primaryPolicy)) { 
        
                   buttonOptions.push({ 
        
                       text: translate('iou.settleBusiness', {formattedAmount}), 
        
                       icon: Expensicons.Building, 
        
                       value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                       backButtonText: translate('iou.business'), 
        
                       subMenuItems: [ 
        
                           { 
        
                               text: translate('iou.payElsewhere', {formattedAmount: ''}), 
        
                               icon: Expensicons.Cash, 
        
                               value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                               onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE, true), 
        
                           }, 
        
                       ], 
        
                   }); 
        
               } 
        
           } 
        
           if (shouldShowApproveButton) { 
        
               buttonOptions.push(approveButtonOption);

What changes do you think we should make in order to solve the problem?

We can push pay with expensify option

if (shouldShowPaywithExpensifyOption) {
            buttonOptions.push(paymentMethods[CONST.IOU.PAYMENT_TYPE.VBBA]);
        }

What alternative solutions did you explore? (Optional)

Tony-MK · 2024-09-03T17:53:24Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - No option 'Pay via Expensify' for receiver

What is the root cause of that problem?

The subMenuItems for both the pay as a business and individual do not include the settle with Expensify option.

Hence the buttonOptions only includes the option to pay the iou elsewhere.

App/src/components/SettlementButton.tsx

Lines 223 to 239 in 0139133

    
           if (isInvoiceReport) { 
        
               if (ReportUtils.isIndividualInvoiceRoom(chatReport)) { 
        
                   buttonOptions.push({ 
        
                       text: translate('iou.settlePersonal', {formattedAmount}), 
        
                       icon: Expensicons.User, 
        
                       value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                       backButtonText: translate('iou.individual'), 
        
                       subMenuItems: [ 
        
                           { 
        
                               text: translate('iou.payElsewhere', {formattedAmount: ''}), 
        
                               icon: Expensicons.Cash, 
        
                               value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                               onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE), 
        
                           }, 
        
                       ], 
        
                   }); 
        
               }

This also happens in the dropdown for business.

App/src/components/SettlementButton.tsx

Lines 242 to 253 in 0139133

    
           buttonOptions.push({ 
        
               text: translate('iou.settleBusiness', {formattedAmount}), 
        
               icon: Expensicons.Building, 
        
               value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
               backButtonText: translate('iou.business'), 
        
               subMenuItems: [ 
        
                   { 
        
                       text: translate('iou.payElsewhere', {formattedAmount: ''}), 
        
                       icon: Expensicons.Cash, 
        
                       value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE, 
        
                       onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE, true), 
        
                   },

What changes do you think we should make in order to solve the problem?

We should add the settle with Expensify option in the subMenuItems array on this line with the code snippet below.

While checking for shouldShowPaywithExpensifyOption and isExpenseReport like this line.

...(isExpenseReport && shouldShowPaywithExpensifyOption ? [{
    text: translate('iou.settleExpensify', {formattedAmount : ''}),
    icon: Expensicons.Wallet,
    value: CONST.IOU.PAYMENT_TYPE.VBBA,
    onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.VBBA),
}] : []),

Or we can push the settle with Expensify option in the subMenuItems before pushing it to the buttonOptions over here.

jaydamani · 2024-09-03T18:32:35Z

Edited by proposal-police: This proposal was edited at 2023-10-02T00:00:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No Pay via Expensify option for invoice

What is the root cause of that problem?

The cause is separate for main and staging,
In main:
The logic for adding "Pay with Expensify" button was removed by this PR which reapplies this PR

In staging (9.0.28-1):
The "Pay with Expensify" button is not added if the iouReport is an invoice

App/src/components/SettlementButton.tsx

Line 198 in a124e4f

    
           const canUseWallet = !isExpenseReport && !isInvoiceReport && currency === CONST.CURRENCY.USD;

App/src/components/SettlementButton.tsx

Lines 209 to 211 in a124e4f

    
           if (canUseWallet) { 
        
               buttonOptions.push(paymentMethods[CONST.IOU.PAYMENT_TYPE.EXPENSIFY]); 
        
           }

The check for !isInvoiceReport was added by this commit which is part of previously mentioned PR but the final changes do not show the change, which is weird.

What changes do you think we should make in order to solve the problem?

Add back the changes to bring back the button. Mainly, we need to add back the value in paymentMethod object and the code to push it in buttonOptions. Then remove !isInvoiceReport from canUseWallet.

If the invoice report needs to be part of canUseWallet then we can make a new similar variable for this called showPayViaExpensify.

https://github.com/Expensify/App/pull/37174/files#diff-475fc90a9838cf6b734f4c860eb57036c3fe04ac7b4c429d1b4e361109aaa6f4L175-L179

What alternative solutions did you explore? (Optional)

jaydamani · 2024-09-03T18:55:40Z

Updated proposal

Added explicit mention of change in canUseWallet for clarification

melvin-bot · 2024-09-03T20:45:25Z

Job added to Upwork: https://www.upwork.com/jobs/~015c21e7f83c78f5bb

melvin-bot · 2024-09-03T20:45:30Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

twisterdotcom · 2024-09-03T20:46:25Z

Hmm... actually... I wonder if these expected result steps are wrong:

Expected Result:

There are options 'Pay elsewhere' and 'Pay via Expensify' in a button dropdown

Actual Result:

There are options 'Pay as business' and 'Pay as an individual' in a button dropdown. No 'Pay via Expensify'

@davidcardoza is this right now? I feel like this makes more sense.

davidcardoza · 2024-09-04T22:11:59Z

Users can't pay an invoice via Expensify just yet. The options should be

Pay as a business
Pay as an individual

Regardless of the selection "Pay elsewhere" should be the only option. We're prioritizing invoice payments as part of the VIP-Bill-pay project. @madmax330

twisterdotcom · 2024-09-05T09:51:04Z

Okay, I think this is just a bug with an ongoing project right? I don't think we need to open this up to contributors right now.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 3, 2024

melvin-bot bot assigned twisterdotcom Sep 3, 2024

twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Sep 3, 2024

melvin-bot bot changed the title ~~Invoice - No option 'Pay via Expensify' for receiver~~ [$250] Invoice - No option 'Pay via Expensify' for receiver Sep 3, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 3, 2024

melvin-bot bot assigned jayeshmangwani Sep 3, 2024

twisterdotcom closed this as completed Sep 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] Invoice - No option 'Pay via Expensify' for receiver #48486

[$250] Invoice - No option 'Pay via Expensify' for receiver #48486

lanitochka17 commented Sep 3, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

MuaazArshad commented Sep 3, 2024

Tony-MK commented Sep 3, 2024

jaydamani commented Sep 3, 2024 •

edited

Loading

jaydamani commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

twisterdotcom commented Sep 3, 2024

Expected Result:

Actual Result:

davidcardoza commented Sep 4, 2024

twisterdotcom commented Sep 5, 2024

[$250] Invoice - No option 'Pay via Expensify' for receiver #48486

[$250] Invoice - No option 'Pay via Expensify' for receiver #48486

Comments

lanitochka17 commented Sep 3, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

MuaazArshad commented Sep 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Tony-MK commented Sep 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

jaydamani commented Sep 3, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

jaydamani commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

twisterdotcom commented Sep 3, 2024

Expected Result:

Actual Result:

davidcardoza commented Sep 4, 2024

twisterdotcom commented Sep 5, 2024

lanitochka17 commented Sep 3, 2024 •

edited by melvin-bot bot

Loading

jaydamani commented Sep 3, 2024 •

edited

Loading