[Search v2.1] - There is a Join button in the paid invoice report when accessed from Search

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has received invoice.

1. Go to staging.new.expensify.com
2. Log in as invoice receiver.
3. Go to invoice room.
4. Pay the invoice
5. Go to Search > Invoices.
6. Click on the paid invoice.

Expected Result:

There will not be a Join button in the report.

Actual Result:

There is a Join button in the paid invoice report when accessed from Search.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6605311_1726482324067.20240916_182304.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a Join button in the paid invoice report when accessed from Search

What is the root cause of that problem?

We are not checking if the invoice is open or closed.

App/src/pages/home/HeaderView.tsx

Line 296 in df070b7

{!isLoading && canJoin && shouldUseNarrowLayout && <View style={[styles.ph5, styles.pb2]}>{joinButton}</View>}

What changes do you think we should make in order to solve the problem?

Adding a check for open or closed invoices will resolve the issue.

App/src/pages/home/HeaderView.tsx

Line 296 in df070b7

{!isLoading && canJoin && shouldUseNarrowLayout && <View style={[styles.ph5, styles.pb2]}>{joinButton}</View>}

const isOpenInvoiceReport = ReportUtils.isOpenInvoiceReport(report);

and

{!isLoading && canJoin && shouldUseNarrowLayout && isOpenInvoiceReport && <View style={[styles.ph5, styles.pb2]}>{joinButton}</View>}

[luacmartins]

I think this might be solved by this PR #49241

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

This is on hold for #49241

[luacmartins]

Hmm I tried testing this again, but for some reason the invoices are not showing up on the Search page at all. @johncschuster could you try the reproducible steps in the OP as well?

[luacmartins]

Actually, I spot the issue in dev and put up a PR to fix it https://github.com/Expensify/Auth/pull/12561

[luacmartins]

This is fixed.