[$250] [A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit

[grgia]

We encountered a ton of lint errors in implementing combinedTrackSubmit
see PR - #49007

Let's fix those in a separate PR for clearer testing

cc @fabioh8010

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838165122581338960
• Upwork Job ID: 1838165122581338960
• Last Price Increase: 2024-11-12
• Automatic offers:
• shubham1206agra | Reviewer | 104148899

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838165122581338960

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[abzokhattab]

Hi @grgia,

is this issue open for external contributors?

Thanks!

[melvin-bot]

@johncschuster, @grgia, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fabioh8010]

@abzokhattab This issue is being handled internally.

[fabioh8010]

Update: I'm holding the PR until #49007 is completed.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[johncschuster]

Not overdue. Still holding the PR

[grgia]

Bumped PR in issue

[johncschuster]

I will be traveling to a funeral tomorrow and will be mostly OOO. I will return on Monday for limited hours and check in on this.

[johncschuster]

Just checking in! It looks like the PR is a WIP 👍

[johncschuster]

No update

[fabioh8010]

Discussing next steps here as it only happens with Expensifail accounts.

[johncschuster]

Thanks for the update! @grgia, I'd like to remove the [HOLD for payment 2024-10-30] from the title since it seems like we're not ready to pay this out. Would you agree with that, or have I missed a payment opportunity?

[grgia]

@johncschuster yep no payment for this one since the PR is a draft and original PR was reverted

[fabioh8010]

Closing the Draft PR as per comment -> #51242 (comment)

[grgia]

@fabioh8010 shall we close this one out?

[shubham1206agra]

@grgia I think you still need to issue payment here.

[grgia]

@shubham1206agra could you point to which review requires payment cc @johncschuster

[shubham1206agra]

@grgia You may need to read this https://docs.google.com/document/d/1BvohU05MTaHnjOD_vwJv_aqDAirv-ChkyRnKCAvOVyQ/edit?tab=t.0#bookmark=id.wfm6lkgp0c6

[johncschuster]

@shubham1206agra thanks for raising that! Just to make sure we're all on the same page, are you referring to this?:

If a contributor has been hired for a job and we decide to close the job before it is successfully completed
50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned.

Or is there something else you're referring to?

[shubham1206agra]

@shubham1206agra thanks for raising that! Just to make sure we're all on the same page, are you referring to this?:

If a contributor has been hired for a job and we decide to close the job before it is successfully completed
50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned.

Or is there something else you're referring to?

@johncschuster I believe it might fall under 100% due if contributor drafted a PR and requested a review.

Since the deploy blocker revert happened due to some unrelated issue that just got discovered when we did migration, and it was not happening on my testing for some reason.

[melvin-bot]

Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Darn, I was trying to get a new Upwork link to auto-generate since the previous job expired 😅 . I'll copy the old one now.

[johncschuster]

Payment Summary:

Contributor: @fabioh8010 does not require payment (Contractor)

Contributor+: @shubham1206agra paid $250 via Upwork

Upwork job here! Please apply

[johncschuster]

Paid! Thanks for your work here, everyone! 🎉