[HOLD for payment 2024-11-18] [Workspace Chats for All] Default QAB to primary workspace if no value

[puneetlath]

In #49344 we are going to make it possible to submit to any workspace, even if you don't have the workspace chat locally.

We also want to make it so that any user that is a member of a policy has a default value for their QAB. So what we should do is update the QAB behavior so that if the nvp doesn't have any data set, and the user is on any group policies, then we set the default value for the QAB to be to submit to their primary group policy, which is stored in nvp_expensify_activePolicyID.

Slack discussion: https://expensify.slack.com/archives/C07NMDKEFMH/p1728585368177889?thread_ts=1728418936.029729&cid=C07NMDKEFMH

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[ishpaul777]

👋 I'll take this after #49344

[puneetlath]

@ishpaul777 taking this off hold now.

[puneetlath]

Back to weekly. We had to revert the previous PR.

[trjExpensify]

We also want to make it so that any user that is a member of a policy has a default value for their QAB. So what we should do is update the QAB behavior so that if the nvp doesn't have any data set, and the user is on any group policies, then we set the default value for the QAB to be to submit to their primary group policy, which is stored in nvp_expensify_activePolicyID

Confirming we'll set this to submitScan on the primary workspace if no value, right?

[puneetlath]

Ok, after discussion, we're going to take a slightly different direction here. Let's only default the QAB if the user:

• has a group workspace as their primary policy
• that workspace has isPolicyExpenseChatEnabled=true
• does not already have a QAB NVP value

Given that. I have taken this off hold and we can go ahead and implement it.

[flaviadefaria]

@puneetlath, what about setting it to submitScan on the primary workspace if there is no value as @trjExpensify mentioned above? Also should we make this a daily?

[puneetlath]

Ah yes, that's what I meant to convey with what I said. We will set it to submitScan on the primary workspace if the primary user meets the criteria in the list:

• user has a group workspace as their primary policy
• that workspace has isPolicyExpenseChatEnabled=true
• user does not already have a QAB NVP value

[dukenv0307]

@puneetlath Can you assign me to this issue? Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Workspace Chats for All] Default QAB to primary workspace if no value #51836

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777 / @dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@dukenv0307 what do you think about adding a regression test here?

[puneetlath]

@ishpaul777 offer here: https://www.upwork.com/nx/wm/offer/104952640
@dukenv0307 offer here: https://www.upwork.com/nx/wm/offer/104952651

Please ping me on this issue when you've accepted them.

[ishpaul777]

Accepted Thanks!

[puneetlath]

@ishpaul777 has been paid.

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: New feature

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This is the new feature

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Sign up with a new account and complete the onboarding process
2. Create a new workspace
3. Open FAB "+" menu, Verify that the Scan receipt QAB is shown

Do we agree 👍 or 👎

[dukenv0307]

@dukenv0307 offer here: https://www.upwork.com/nx/wm/offer/104952651

@puneetlath I will request payment in NewDot, thanks.

[puneetlath]

Regression test issue: https://github.com/Expensify/Expensify/issues/446312

Payment summary:

• C - $250 - @ishpaul777 - paid via Upwork
• C+ - $250 - @dukenv0307 - to be paid via NewDot

Thanks everyone!