[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11

[github-actions]

Release Version: 9.0.60-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [HelpDot] Fix List Spacing in Expensify Help #47200
• [InternalQA] Fix crash when disconnecting from Netsuite #47232
• Allow all even accountIDs to use "Create Expense" #50066
• Use small icon in tabs #50324
• fix: unify distance rates display #50783
• fix: update navigation for qab #51057
• Require validateCode when requesting replacement cards #51147
• Update getSubmitToAccountID with category and tag approver #51196
• fix: Members are unselected when refresh Add message page and go back #51227
• Feat: Improve isLoading to prevent loading for undefined #51360
• Show search action buttons #51445
• Add GTM event tracking #51599
• Fix pending join workspace isn't visible in the WS list #51631
• [NO QA] feat: Step 3 UI #51667
• fix: App freeze when clearing cache #51725
• Add the ValidateCodeActionModal step to the 2FA #51882
• Remove param v2 for ApproveMoneyRequest #51902
• Bump Onyx to v2.0.78 #51942
• fix: Add Type column to workspace feeds #51946
• [NoQA] Add generic way for attributes, limit custom attributes for firebase #51960
• fix empty categories from briefly displaying when search begins #52009
• Update Set-Notifications.md #52010
• bump react-native-live-markdown to v0.1.180 #52017
• Fix - QBO - Back button on workspace editor returns to Accounting after changing Import settings #52057
• Fix - change maxExpenseAmountNoReceipt to maxAmountNoReceipt for policy… #52058
• Fix - Duplicate system message when resolving duplicates selecting "Keep all" #52060
• Fix web camera not loading #52083
• Stop displaying some advanced filters when they have no data #52102
• [NOQA] docs: add left hand navigation readme file #52105
• fix prevent brief hiding of Expense preview when returning to report … #52119
• Use conciergeChatReportID returned from OpenApp #52141
• feature(search): hide invoice type from search LHN #52148
• Update en.ts #52153
• [No QA] Update en.ts #52154
• Fix: Inconsistency in displaying Search icon when returning to expenses opened from Search #52160
• Updating the Create-an-Expense article as part of "Improve how we notify users of iou/expense report submissions" project #52161
• Check for empty object for the onboarding flow too #52175
• [NO QA] Create plan-types-and-pricing.md #52177
• [NO QA] chore: remove unused properties from Report type #52182
• [No QA] Let HybridApp handle ND links - update assetlinks.json #52184
• [Search v2.5] Allow Searching for multiple statuses #52185
• Fix - Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process #52188
• Replace terms URLs and match with olddot #52205
• [NO QA] fix wording of helpdot article #52207
• Update en.ts #52218
• Fix bundle install on macOS 15.1 #52227
• NO QA - Create assign-a-task page #52229
• Update Request-the-Card.md #52230
• Don't show two creation options at the same time in the workspace switcher #52254
• Fix API requests on the HybridApp #52255
• Update Enable-Global-Reimbursements.md to remove beta wording #52265
• [NO QA] Update Quickbooks-Online-Troubleshooting.md #52270
• Update selfDMReportID when opening/closing FAB #52275
• Fix - Distance-Distance receipt placeholder icon is hardly visible when expense is submitted offline #52279
• hide 'Request early cancellation' option until after first billing #52282
• Update en.ts #52284
• Update en.ts #52285
• chore: add minor readme updates #52290
• fixes for scroll sync behavior #52291
• fix: View your subscription link opens Subscription page then back to workspace #52295
• Fix hidden members is shown when creating workspace from iou payment #52296
• Revert "fix: unify distance rates display" #52406
• [CP Staging] Disable Search action button offline #52412
• [CP Staging] Revert "Show search action buttons" #52434

Internal QA:

• Workspace Feed - Use full cardsList instead of user cardList #52152 - @mountiny
• Workspace Feed - update details cardName to use full name instead of 4 digits #52151 - @mountiny
• Workspace Feed - remove unneeded extractDate from the startDate step #52150 - @mountiny
• Fix: Change offline pattern for unassigning cards #52109 - @mountiny
• [Workspace feeds] Add search bar if cards assignment list has 8+ cards #51955 - @mountiny

Deploy Blockers:

• [HOLD for payment 2024-11-29] Verify account - "Code requested" only shows in 2FA page after user opens contact method page #52336
• Expensify Card - No error message when incorrect code is entered when deactivating card #52338
• [HOLD for payment 2024-12-05] Verify account - No right side window animation when 2FA setup is dismissed #52339
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-11-20] Distance - Distance rate with 4 decimal values are not shown correctly in expense report #52342
• Expense preview - Preview gets duplicated on submit 2 duplicate expenses if any already exist #52343
• [HOLD for payment 2024-12-03] [Search v1.2] - When paying via search, changes are not seen in LHN and expense preview #52360
• Search - "Save search" is shown when no category is displayed #52361
• [PAID] [Search v2.5] - Category field is still present after deleting all the categories #52362
• [HOLD for payment 2024-12-03] [Search v1.2] - Pay button displayed next to expense after unapproving #52364
• [HOLD for payment 2024-12-03] [Search v1.2] - Button loads infinitely when approving or paying expense in Search in offline mode #52365
• [HOLD for payment 2024-12-03] [Search v1.2] - Paid invoice shows "View" button instead of "Paid" label #52366
• [HOLD for payment 2024-12-03] [Search v1.2] Invoice preview still shows "User owes x" after the invoice is paid #52367
• [HOLD for payment 2024-12-03] [Search v1.2] Android - Expense - Unexpected error when submitting expense to same WS after paying another #52368
• [HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369
• [HOLD for payment 2024-11-26] Card - In issue card page, no outline box is shown around amount #52370
• [HOLD for payment 2024-12-03] [Search v1.2] - Pay button can be clicked many times without error when bank account is not set up #52371
• [HOLD for payment 2024-12-03] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search #52375
• [HOLD for payment 2024-12-03] [Search v1.2] - Unable to pay held expense in Search #52377
• [Search v2.5] Tax rate field is displayed after disabling Taxes #52378
• [$250] Android - When cancelling payment, "Done" message displayed instead of "Pay" button #52403
• [HOLD for payment 2024-12-03] [Search v1.2] - Approve button is not disabled in Search when "Prevent self-approvals" is enabled #52404
• [HOLD for payment 2024-12-03] [Search v1.2] - Approve button disappears after deleting expense in report that has comments #52411
• [HOLD for payment 2024-12-03] [Search v1.2] - Pay button appears for report that will be auto-paid and it reappears after clicked #52418

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.60-0 🚀

[francoisl]

Demoting #52338 - backend fix
Demoting #52336 - edge case
Demoting #52339 - new feature, not breaking any flow
Demoting #52343 - backend bug

[izarutskaya]

Regression is at 73 % completed

All iOS slots are pending. Still waiting iOS build

PRs:
#50783 - Failing with #52342
#51147 - Failing with #52338
#51942 - KI found #52359 only Hybrid app Pending validation on iOS
#52060 - KI #52343
#52102 - Failing with #52362
#52160 - KI #51730

Blockers:
#52342
#52360
#52361

[Julesssss]

Demoted #52369

[kavimuru]

Regression is 3% left

Unchecked PRs:
#50783 - Failing with #52342
#51147 - Failing with #52338
#51196 Desktop and iOS pending validation
#51631 failing with #52394 repro in PROD checking it off.
#52102 iOS validation pending
#52141 iOS validation pending
#52148 failing with #52379 repro in PROD , but bug closed as intended - checking it off
#52185 - iOS validation is pending
#52227 (comment) checking it off as per the comment
#52255 pending validation in Desktop and iOS

[francoisl]

Demoting #52367, appears to be fixed on v9.0.60-2

[kavimuru]

Regression is completed.
unchecked PRs:
#50783 - Failing with #52342
#51147 - Failing with #52338
#51631 failing with #52394 repro in PROD checking it off.
#52102 failing with #52362 and #52378
#52227 (comment) checking it off as per the comment
#52255 - blocked in desktop "try new expensify" not redirecting to app from web repro in PROD checking it off.

Blockers:
#52366
#52368
#52375
#52404
#52418

[francoisl]

We just CP'ed a PR that fixes a lot of blockers, going through them now and will update if issues are confirmed fixed

#52342 confirmed fixed on staging - checking #50783
#51147 backend fix - checking
#52102 - commented as not a blocker, checking
CP #52406 - confirmed fixed on staging
CP #52412 - I tested on web, confirmed
CP #52434 - Fixes all the blockers below
#52366 - no longer applies, different UI
#52368 - working
#52375 - no longer applies, different UI with revert
#52404 - no longer applies, different UI with revert
#52418 - no longer applies, different UI with revert

[francoisl]

All blockers resolved, checking dashboards and this should be ready to close.

[francoisl]

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @applausebot requires payment (Needs manual offer from BZ)

[luacmartins]

There's no payment needed here Melv!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @applausebot requires payment (Needs manual offer from BZ)