Expense preview - Preview gets duplicated on submit 2 duplicate expenses if any already exist

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #52060

Action Performed:

1. Log in to New Expensify
2. Navigate to workspace chat
3. Submit an expense
4. Submit another different expense
5. Submit third expense, the same as in step 4.

Expected Result:

One expense preview should be displayed

Actual Result:

Duplicate expense preview appears after submitting duplicate expenses

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6661817_1731357818722.2024-11-11_21-20-22.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

bandicam.2024-11-11.22-53-03-766.mp4

[francoisl]

I think this is a backend bug, I can still repro if I check out NewDot's production version locally, and can no longer repro if I check out Web-E's production branch.

[francoisl]

This is caused by https://github.com/Expensify/Web-Expensify/pull/44299, cc @yuwenmemon. Removing the DeloyBockerCacsh label.

[yuwenmemon]

Hmmmm... This only seems to happen when you are the workspace's admin in addition to the submitter..

[yuwenmemon]

Ah, we're not removing the optimistic report action, and updating the old one that actually exists...

[yuwenmemon]

I have a fix but will create a revert the offending PR in the meantime so we can move forward with the deploy if we need to before the next Auth deploy cc @mountiny

[mountiny]

Asked for a retest here https://expensify.slack.com/archives/C9YU7BX5M/p1731434051476589

[kavimuru]

Not able to reproduce

2024-11-12.19-02-08.mp4

[brunovjk]

Is this the same bug: Two previews are created after creating 2 or more expenses

v9.0.66-8

bug_production.mov

cc: @yuwenmemon @mountiny

Thank you for your help!

[mountiny]

@brunovjk yes that seems like a bug

[mountiny]

Can you report in Slack if its not reported yet?

[brunovjk]

@mountiny I'm a bit confused, the bug has already been reported here, right? Thanks.

[mountiny]

Yes, I saw it reported there just after this message from you

[brunovjk]

Great then :D