[HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369

IuliiaHerets · 2024-11-12T10:44:19Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses.
Pay the expenses.
Go to Search > All.

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6662249_1731401348204.20241112_164526.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021856301612409763010
Upwork Job ID: 1856301612409763010
Last Price Increase: 2024-11-12

Issue Owner

Current Issue Owner: @luacmartins

melvin-bot · 2024-11-12T10:44:28Z

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-11-12T10:44:29Z

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot · 2024-11-12T10:44:30Z

💬 A slack conversation has been started in #expensify-open-source

github-actions · 2024-11-12T10:44:35Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Julesssss · 2024-11-12T11:42:30Z

Reproducible in production?: N/A - new feature, doesn't exist in prod

Demoting

melvin-bot · 2024-11-12T11:42:49Z

Job added to Upwork: https://www.upwork.com/jobs/~021856301612409763010

melvin-bot · 2024-11-12T11:42:54Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

Julesssss · 2024-11-12T11:44:04Z

Hi @IuliiaHerets, the reproduction steps aren't added yet. Could you please tag me when they are listed, thanks.

klajdipaja · 2024-11-12T14:19:11Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The status of the transaction does not show as paid when the transaction is part of a thread with multiple transaction and all transactions are paid.

What is the root cause of that problem?

To build the rows of the search results we call SearchUIUtils.getSections in this line https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/components/Search/index.tsx#L209.
When the search is for all expenses it then calls: https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/libs/SearchUIUtils.ts#L212C10-L212C33.

In this function we try to resolve the action of the transaction in this line:
https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/libs/SearchUIUtils.ts#L227
The root cause is then hidden on this block:
https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/libs/SearchUIUtils.ts#L253-L256
because of this part of the conditon which is true: (isTransaction && !data[key].isFromOneTransactionReport)
To sum it up, it seems like it has been the intended behaviour that when the transaction is part of multiple transaction report it will show the View action.

What changes do you think we should make in order to solve the problem?

We should remove that part of the condition that checks for single transaction and make the conditon into this:

    if (!isTransaction && !isReportEntry(key)) {
        return CONST.SEARCH.ACTION_TYPES.VIEW;
    }

And rely on the action returned by the backend for this transaction instead of using the isSettled method which relies on the report that the transaction belongs to because the report does not have the right data to understand individual transaction status.

To do that we can at this line after when we resolved the transaction:
https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/libs/SearchUIUtils.ts#L257.
this block:

   if (transaction?.action === CONST.SEARCH.ACTION_TYPES.PAID) {
        return CONST.SEARCH.ACTION_TYPES.PAID;
    }

What alternative solutions did you explore? (Optional)

twilight2294 · 2024-11-12T14:33:38Z

Edited by proposal-police: This proposal was edited at 2024-11-12 14:35:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paid expenses do not have "Paid" label when the expenses are grouped expenses

What is the root cause of that problem?

When we get the actions, we check if the transaction is From One Transaction Report, for the bug description, it is false so we return the action to be CONST.SEARCH.ACTION_TYPES.VIEW:

App/src/libs/SearchUIUtils.ts

Lines 253 to 255 in cd3f30f

    
           if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport)) { 
        
               return CONST.SEARCH.ACTION_TYPES.VIEW; 
        
           }

What changes do you think we should make in order to solve the problem?

Here, to fix this, we should also check whether the report is a isMoneyRequestReport and then only return the type as view, we do that but we do it below, after the above check:

App/src/libs/SearchUIUtils.ts

Lines 260 to 263 in cd3f30f

    
           // We don't need to run the logic if this is not a transaction or iou/expense report, so let's shortcircuit the logic for performance reasons 
        
           if (!ReportUtils.isMoneyRequestReport(report)) { 
        
               return CONST.SEARCH.ACTION_TYPES.VIEW; 
        
           }

So we should update the code as such:

function getAction(data: OnyxTypes.SearchResults['data'], key: string): SearchTransactionAction {
    const isTransaction = isTransactionEntry(key);
    const transaction = isTransaction ? data[key] : undefined;
    const report = isTransaction ? data[`${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`] : data[key];


    if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport && !ReportUtils.isMoneyRequestReport(report))) {
        return CONST.SEARCH.ACTION_TYPES.VIEW;
    }

This will make sure that we only return the type as view if the report is a money request report.

What alternative solutions did you explore? (Optional)

klajdipaja · 2024-11-12T14:35:58Z

In the Paid section we also have the View button displaying for transactions that are part of the group.
I don't think that's what the reported issue is about by looking at the recording but if that is also part of the issue, here is what we would need to do to fix that:

We have a forced View mode in ActionCell.tsx when the parent and current transaction are both PAID.

App/src/components/SelectionList/Search/ActionCell.tsx

Line 51 in cd3f30f

    
           const shouldUseViewAction = action === CONST.SEARCH.ACTION_TYPES.VIEW || (parentAction === CONST.SEARCH.ACTION_TYPES.PAID && action === CONST.SEARCH.ACTION_TYPES.PAID);

If we want to show the Paid checkmark we need to remove the shouldUseViewAction boolean.
And also modify the condition here:

App/src/components/SelectionList/Search/ActionCell.tsx

Line 53 in cd3f30f

    
           if ((parentAction !== CONST.SEARCH.ACTION_TYPES.PAID && action === CONST.SEARCH.ACTION_TYPES.PAID) || action === CONST.SEARCH.ACTION_TYPES.DONE) {

to remove the part that checks for the parent action:

    if (action === CONST.SEARCH.ACTION_TYPES.PAID || action === CONST.SEARCH.ACTION_TYPES.DONE) {

Nodebrute · 2024-11-12T14:51:00Z

Edited by proposal-police: This proposal was edited at 2024-11-12 14:54:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paid expenses do not have "Paid" label when the expenses are grouped expenses

What is the root cause of that problem?

For combined transactions, isFromOneTransactionReport will be false, which triggers the conditions below and causes View to be shown instead of Paid.

App/src/libs/SearchUIUtils.ts

Lines 253 to 255 in cd3f30f

    
           if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport)) { 
        
               return CONST.SEARCH.ACTION_TYPES.VIEW; 
        
           }

but isFromOneTransactionReport was added for the below case where we don't want to show pay for individual transactions

What changes do you think we should make in order to solve the problem?

Remove (isTransaction && !data[key].isFromOneTransactionReport)

App/src/libs/SearchUIUtils.ts

Line 253 in cd3f30f

if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport)) {

Move this code block above this line

App/src/libs/SearchUIUtils.ts

Lines 291 to 297 in cd3f30f

    
           if (IOU.canIOUBePaid(report, chatReport, policy, allReportTransactions, false, chatReportRNVP, invoiceReceiverPolicy)) { 
        
               return CONST.SEARCH.ACTION_TYPES.PAY; 
        
           } 
        
           if (IOU.canApproveIOU(report, policy)) { 
        
               return CONST.SEARCH.ACTION_TYPES.APPROVE; 
        
           }

and at last change this line

App/src/libs/SearchUIUtils.ts

Line 261 in cd3f30f

if (!ReportUtils.isMoneyRequestReport(report)) {

 if (!ReportUtils.isMoneyRequestReport(report) || (isTransaction && !data[key].isFromOneTransactionReport)) {
        return CONST.SEARCH.ACTION_TYPES.VIEW;
    }

This solution will not break anything

Screen.Recording.2024-11-12.at.7.53.20.PM.mov

What alternative solutions did you explore? (Optional)

Alternatively, we can remove this (isTransaction && !data[key].isFromOneTransactionReport)

App/src/libs/SearchUIUtils.ts

Line 253 in cd3f30f

    
           if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport)) {

and after this line we can add

 if(isTransaction && !data[key].isFromOneTransactionReport){
    return CONST.SEARCH.ACTION_TYPES.VIEW;
  }

Solution 3
We can also change this

App/src/libs/SearchUIUtils.ts

Lines 252 to 255 in cd3f30f

    
           const isTransaction = isTransactionEntry(key); 
        
           if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport)) { 
        
               return CONST.SEARCH.ACTION_TYPES.VIEW; 
        
           }

   if ((!isTransaction && !isReportEntry(key)) || (isTransaction && !data[key].isFromOneTransactionReport && !ReportUtils.isSettled(report) && !ReportUtils.isClosedReport(report))) {
        return CONST.SEARCH.ACTION_TYPES.VIEW;
    }

Anaslancer · 2024-11-12T16:21:02Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Paid expenses do not have "Paid" label when the expenses are grouped expenses

What is the root cause of that problem?

Whenever we pay several transactions once, isFromOneTransactionReport of transaction is always false.
Btw, in this below code, if isFromOneTransactionReport is false, getAction return 'view'.
https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/libs/SearchUIUtils.ts#L253-L255
So we are watching the 'view' label in expenses search list.

What changes do you think we should make in order to solve the problem?

If we want to see 'paid' at the moment, we should remove this below condition.
https://github.com/klajdipaja/Expensify-App/blob/cd3f30f73a18c29532d6886b4bb3744fd700ab9d/src/libs/SearchUIUtils.ts#L253-L255
Here is the changed code.

    if (!isTransaction && !isReportEntry(key)) {
        return CONST.SEARCH.ACTION_TYPES.VIEW;
    }

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: anasup1995@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

melvin-bot · 2024-11-12T16:21:04Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

luacmartins · 2024-11-13T19:36:36Z

Not ready to be paid, we just reverted the PR and I'll be working on a fix for this.

luacmartins · 2024-11-13T20:30:01Z

@abekkala I'll unassign you since we reverted the PR and fixed this issue. I'm keeping it open to make sure I address the issue in the v2 of my PR.

melvin-bot · 2024-11-14T00:43:17Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-21. 🎊

melvin-bot · 2024-11-14T00:43:18Z

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-11-25T12:02:12Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2024-11-26T16:17:13Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-11-26T16:17:15Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Show search action buttons v2 #52441

If no regressions arise, payment will be issued on 2024-12-03. 🎊

melvin-bot · 2024-11-26T16:17:17Z

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-11-27T22:54:45Z

This is done

IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 12, 2024

melvin-bot bot assigned abekkala and Julesssss Nov 12, 2024

melvin-bot bot added the Daily KSv2 label Nov 12, 2024

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 12, 2024

github-actions bot mentioned this issue Nov 12, 2024

[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11 #52320

Closed

95 tasks

Julesssss added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 12, 2024

melvin-bot bot changed the title ~~Search - Paid expenses do not have "Paid" label when the expenses are grouped expenses~~ [$250] Search - Paid expenses do not have "Paid" label when the expenses are grouped expenses Nov 12, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 12, 2024

melvin-bot bot assigned getusha Nov 12, 2024

luacmartins added Daily KSv2 and removed Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Nov 13, 2024

luacmartins changed the title ~~[HOLD for payment 2024-11-20] [$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses~~ [$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses Nov 13, 2024

luacmartins unassigned abekkala Nov 13, 2024

luacmartins mentioned this issue Nov 13, 2024

[HOLD for payment 2024-12-03] [Search v1] Implement next step actions in Search #51898

Closed

13 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 14, 2024

melvin-bot bot changed the title ~~[$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses~~ [HOLD for payment 2024-11-21] [$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses Nov 14, 2024

luacmartins changed the title ~~[HOLD for payment 2024-11-21] [$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses~~ [$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses Nov 14, 2024

luacmartins removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 14, 2024

luacmartins changed the title ~~[$250] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses~~ [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses Nov 14, 2024

luacmartins added the Reviewing Has a PR in review label Nov 20, 2024

luacmartins mentioned this issue Nov 20, 2024

Show search action buttons v2 #52441

Merged

50 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024

melvin-bot bot changed the title ~~[Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses~~ [HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses Nov 26, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024

luacmartins closed this as completed Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369

[HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369

IuliiaHerets commented Nov 12, 2024 •

edited by luacmartins

Loading

melvin-bot bot commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

Julesssss commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

Julesssss commented Nov 12, 2024

klajdipaja commented Nov 12, 2024

twilight2294 commented Nov 12, 2024 •

edited by github-actions bot

Loading

klajdipaja commented Nov 12, 2024 •

edited

Loading

Nodebrute commented Nov 12, 2024 •

edited

Loading

Anaslancer commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

luacmartins commented Nov 13, 2024

luacmartins commented Nov 13, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 25, 2024

melvin-bot bot commented Nov 26, 2024

melvin-bot bot commented Nov 26, 2024

melvin-bot bot commented Nov 26, 2024

luacmartins commented Nov 27, 2024

[HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369

[HOLD for payment 2024-12-03] [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369

Comments

IuliiaHerets commented Nov 12, 2024 • edited by luacmartins Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

Julesssss commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

melvin-bot bot commented Nov 12, 2024

Julesssss commented Nov 12, 2024

klajdipaja commented Nov 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

twilight2294 commented Nov 12, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

klajdipaja commented Nov 12, 2024 • edited Loading

Nodebrute commented Nov 12, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Anaslancer commented Nov 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Contributor details

melvin-bot bot commented Nov 12, 2024

luacmartins commented Nov 13, 2024

luacmartins commented Nov 13, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 25, 2024

melvin-bot bot commented Nov 26, 2024

melvin-bot bot commented Nov 26, 2024

melvin-bot bot commented Nov 26, 2024

luacmartins commented Nov 27, 2024

IuliiaHerets commented Nov 12, 2024 •

edited by luacmartins

Loading

twilight2294 commented Nov 12, 2024 •

edited by github-actions bot

Loading

klajdipaja commented Nov 12, 2024 •

edited

Loading

Nodebrute commented Nov 12, 2024 •

edited

Loading