Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid - Launch - App is reloaded everytime that it´s backgrounded and opened again. #52874

Closed
1 of 8 tasks
izarutskaya opened this issue Nov 21, 2024 · 18 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.65-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open the Expensify app.
  2. Open any chat.
  3. Background the app.
  4. Reopen the app.
  5. Verify that the app doesn´t load again and that you remain on the opened chat.
  6. Navigate to a different section. (For Example: Search)
  7. Background the app.
  8. Reopen the app.
  9. Verify that the app is not loaded again and that you remain on the opened section.

Expected Result:

App shouldn´t be reloaded everytime that is backgrounded and reloaded and the user should remain on the same chat or section that before it was backgrounded.

Actual Result:

The app is reloaded everytime that is backgrounded and reopened and the user returns to inbox instead of remaining on the opened chat or section.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6671531_1732169764251.Reload.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 21, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 21, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 21, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@cristipaval
Copy link
Contributor

Looking

@cristipaval
Copy link
Contributor

cristipaval commented Nov 21, 2024

ok, I could reproduce with 9.0.65-1

@cristipaval
Copy link
Contributor

cristipaval commented Nov 21, 2024

I wonder if this is the offending PR, @Julesssss @war-in

@cristipaval
Copy link
Contributor

I wonder if this is the offending PR, @Julesssss @war-in

if yes, then I think it doesn't make sense to block the NewDot deployment, given that it needs to be fixed in the OldApp repository.

@cristipaval
Copy link
Contributor

cristipaval commented Nov 21, 2024

More context here.
TLDR: It seems that the root cause is from the OldApp code, so it might not make sense to deploy the App deployment.
But given that we also release HybridApp when we release New Expensify, this is a valid blocker.

@cristipaval
Copy link
Contributor

Ok, so the next step is to test the revert of what we think the offending PR is to confirm, and if so, consider whether we want to fix this or revert the PR.

@Julesssss
Copy link
Contributor

I'd prefer to fix this, it should be as simple as changing the Activity launch type. I will test a build

@Julesssss
Copy link
Contributor

@Julesssss Julesssss added the Reviewing Has a PR in review label Nov 22, 2024
@Julesssss
Copy link
Contributor

Alright, so we just need an App bump for this to be testable by QA.

@Julesssss
Copy link
Contributor

@Julesssss
Copy link
Contributor

Reopening for QA verification: #52874

@Julesssss Julesssss reopened this Nov 22, 2024
@Julesssss
Copy link
Contributor

Julesssss commented Nov 22, 2024

@Julesssss Julesssss self-assigned this Nov 22, 2024
@chiragsalian
Copy link
Contributor

Fix has been tested - https://expensify.slack.com/archives/C9YU7BX5M/p1732293554743679?thread_ts=1732291578.881379&cid=C9YU7BX5M
removing blocker label.

@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Nov 22, 2024
@alexpensify
Copy link
Contributor

alexpensify commented Dec 3, 2024

Keeping closed - this one was handled internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants